Skip to content

{AKS} Add MIG profiles to aks-preview - #10439

Merged
JaysonTaiMicrosoft merged 5 commits into
Azure:mainfrom
karenychen:karenchen/add-mig-profiles
Oct 9, 2026
Merged

JaysonTaiMicrosoft merged 5 commits into
Azure:mainfrom
karenychen:karenchen/add-mig-profiles

Conversation

@karenychen

Copy link
Copy Markdown
Contributor

Description

Add preview Azure CLI support for properties.gpuProfile.nvidia.migProfiles on agent pools.

  • Adds space-delimited --gpu-mig-profiles to az aks nodepool add and az aks nodepool update.
  • Validates each value against MIG1g, MIG2g, MIG3g, MIG4g, and MIG7g.
  • Preserves profile order and duplicates and leaves omitted input unset.
  • Preserves existing nested NVIDIA GPU settings while composing with --gpu-mig-strategy.
  • Documents the option and adds focused parsing, mutation, omission, and serialization coverage.

Example:

az aks nodepool add \
  --resource-group MyResourceGroup \
  --cluster-name MyManagedCluster \
  --name gpunp \
  --enable-managed-gpu \
  --gpu-mig-strategy Mixed \
  --gpu-mig-profiles MIG1g MIG2g MIG2g MIG2g

Testing

  • python -m unittest azext_aks_preview.tests.latest.test_agentpool_decorator azext_aks_preview.tests.latest.test_agentpool_update azext_aks_preview.tests.latest.test_update_agentpool_profile_preview (170 tests, 2 skipped)
  • pylint src/aks-preview/azext_aks_preview --rcfile=pylintrc (10.00/10)
  • flake8 --statistics --append-config=.flake8 src/aks-preview
  • python scripts/ci/test_index.py -q (9 tests, 2 skipped)
  • git diff --check

Copilot AI balanced review requested due to automatic review settings October 6, 2026 21:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The additive implementation follows existing SDK and decorator patterns, with focused regression coverage and no substantiated blocking issues.

Review effort: Balanced
Findings: None

What changed in this PR

Adds preview NVIDIA MIG profile support to AKS node-pool add and update commands.

Changes:

  • Registers validated, ordered profile lists with duplicate support.
  • Integrates profile handling into existing GPU decorators.
  • Adds help, release notes, and parsing, mutation, omission, and serialization tests.
File Description
src/​aks-preview/​HISTORY.rst Announces the new option.
src/​aks-preview/​azext_aks_preview/​tests/​latest/​test_update_agentpool_profile_preview.py Covers update-flow integration.
src/​aks-preview/​azext_aks_preview/​tests/​latest/​test_agentpool_update.py Tests argument parsing and validation.
src/​aks-preview/​azext_aks_preview/​tests/​latest/​test_agentpool_decorator.py Tests profile handling and serialization.
src/​aks-preview/​azext_aks_preview/​custom.py Accepts profiles in command handlers.
src/​aks-preview/​azext_aks_preview/​agentpool_decorator.py Applies profiles to GPU settings.
src/​aks-preview/​azext_aks_preview/​_params.py Registers preview arguments.
src/​aks-preview/​azext_aks_preview/​_help.py Documents usage and service restrictions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@yonzhan

Copy link
Copy Markdown
Collaborator

AKS

FumingZhang
FumingZhang previously approved these changes Oct 7, 2026
FumingZhang
FumingZhang previously approved these changes Oct 8, 2026
@JaysonTaiMicrosoft

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@JaysonTaiMicrosoft

Copy link
Copy Markdown
Contributor

Karen Chen (@karenychen) Please sync with main to pull in the latest changes from src/index.json to fix the CI error

@JaysonTaiMicrosoft

Copy link
Copy Markdown
Contributor

Karen Chen (@karenychen) Please resolve the merge conflicts

…rofiles

# Conflicts:
#	src/aks-preview/HISTORY.rst
@karenychen

Copy link
Copy Markdown
Contributor Author

JaysonTaiMicrosoft merged conflict is resolved by bumping the preview CLI version again

@karenychen

Copy link
Copy Markdown
Contributor Author

JaysonTaiMicrosoft All tests finished running successfully, could you help merge in this PR? Many thanks!

@JaysonTaiMicrosoft
JaysonTaiMicrosoft merged commit ef1498d into Azure:main Oct 9, 2026
24 checks passed
@azclibot

Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ aks-preview-22.0.0b12 ] : https://dev.azure.com/msazure/One/_build/results?buildId=184904642&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants