Repository navigation
{AKS} Add MIG profiles to aks-preview - #10439
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The additive implementation follows existing SDK and decorator patterns, with focused regression coverage and no substantiated blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Adds preview NVIDIA MIG profile support to AKS node-pool add and update commands.
Changes:
- Registers validated, ordered profile lists with duplicate support.
- Integrates profile handling into existing GPU decorators.
- Adds help, release notes, and parsing, mutation, omission, and serialization tests.
| File | Description |
|---|---|
| src/aks-preview/HISTORY.rst | Announces the new option. |
| src/aks-preview/azext_aks_preview/tests/latest/test_update_agentpool_profile_preview.py | Covers update-flow integration. |
| src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_update.py | Tests argument parsing and validation. |
| src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py | Tests profile handling and serialization. |
| src/aks-preview/azext_aks_preview/custom.py | Accepts profiles in command handlers. |
| src/aks-preview/azext_aks_preview/agentpool_decorator.py | Applies profiles to GPU settings. |
| src/aks-preview/azext_aks_preview/_params.py | Registers preview arguments. |
| src/aks-preview/azext_aks_preview/_help.py | Documents usage and service restrictions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
AKS |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
Karen Chen (@karenychen) Please sync with main to pull in the latest changes from src/index.json to fix the CI error |
|
Karen Chen (@karenychen) Please resolve the merge conflicts |
…rofiles # Conflicts: # src/aks-preview/HISTORY.rst
|
JaysonTaiMicrosoft merged conflict is resolved by bumping the preview CLI version again |
|
JaysonTaiMicrosoft All tests finished running successfully, could you help merge in this PR? Many thanks! |
|
[Release] Update index.json for extension [ aks-preview-22.0.0b12 ] : https://dev.azure.com/msazure/One/_build/results?buildId=184904642&view=results |
Description
Add preview Azure CLI support for
properties.gpuProfile.nvidia.migProfileson agent pools.--gpu-mig-profilestoaz aks nodepool addandaz aks nodepool update.MIG1g,MIG2g,MIG3g,MIG4g, andMIG7g.--gpu-mig-strategy.Example:
Testing
python -m unittest azext_aks_preview.tests.latest.test_agentpool_decorator azext_aks_preview.tests.latest.test_agentpool_update azext_aks_preview.tests.latest.test_update_agentpool_profile_preview(170 tests, 2 skipped)pylint src/aks-preview/azext_aks_preview --rcfile=pylintrc(10.00/10)flake8 --statistics --append-config=.flake8 src/aks-previewpython scripts/ci/test_index.py -q(9 tests, 2 skipped)git diff --check