Repository navigation
{AKS} Preserve resolved executable paths in aks-preview - #10444
Open
FumingZhang wants to merge 5 commits into
Open
FumingZhang wants to merge 5 commits into
FumingZhang wants to merge 5 commits into
Conversation
Use the selected executable consistently in diagnostics, credential conversion, and Bastion. Preserve argument boundaries and shell behavior, and add regression coverage for executable lookup and error handling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Bastion can still suppress non-zero tunnel failures and can misclassify shells based on directory names.
2 open findings
What changed in this PR
Updates AKS Preview commands to consistently reuse resolved executable paths and safely preserve argument boundaries.
Changes:
- Adds cross-platform executable discovery.
- Uses resolved paths for diagnostics, credentials, and Bastion subprocesses.
- Adds regression tests and release notes.
| File | Description |
|---|---|
HISTORY.rst |
Records executable-path improvements. |
_helpers.py |
Expands executable resolution behavior. |
custom.py |
Reuses the resolved kubelogin path. |
aks_diagnostics.py |
Pins resolved diagnostic tool paths. |
bastion/bastion.py |
Revises shell and subprocess handling. |
test_helpers.py |
Tests executable discovery. |
test_custom.py |
Tests credential conversion paths. |
test_aks_diagnostics.py |
Tests diagnostic executable handling. |
test_aks_bastion.py |
Tests Bastion subprocess behavior. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Address review feedback by reporting nonzero tunnel process exits after cancelling the subshell, while preserving normal cancellation cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Address review feedback by normalizing the executable basename before selecting shell-specific arguments. Preserve quoted paths and cover directory-name collisions on POSIX and Windows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
AKS |
|
FumingZhang Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{AKS} Preserve resolved executable paths in aks-preview
Summary
Related commands
az aks kollectaz aks kanalyzeaz aks get-credentialsaz aks bastion tunnelValidation
azdev linter --min-severity medium: passed.azdev style aks-preview: pylint and flake8 passed.python -m build --wheel --no-isolation src/aks-preview: passed.python scripts/ci/test_index.py -q: passed (7 tests passed, 2 skipped).Reviewer notes
2025-05-01, while the app-routing test recording contains2026-02-01. This unrelated recording/SDK mismatch is not changed by this PR.