Repository navigation
[SSH] Fix Arc proxy registry hostname for active cloud - #10449
Open
masonfaulkner wants to merge 1 commit into
Open
masonfaulkner wants to merge 1 commit into
masonfaulkner wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested a review
from Yong Zhang (yonzhan)
October 8, 2026 17:08
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution masonfaulkner! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation follows established cloud-hostname resolution patterns and includes focused coverage for the changed behavior.
0 open findings
What changed in this PR
Updates Arc SSH proxy downloads to use the registry hostname associated with the active Azure cloud.
Changes:
- Derives the MCR hostname from the active cloud endpoint.
- Propagates command context through proxy installation.
- Adds tests and bumps the SSH extension to 2.0.10.
| File | Description |
|---|---|
src/ssh/setup.py |
Bumps the extension version. |
src/ssh/HISTORY.md |
Documents the registry fix. |
src/ssh/azext_ssh/custom.py |
Passes command context to proxy installation. |
src/ssh/azext_ssh/constants.py |
Separates the registry repository path from its hostname. |
src/ssh/azext_ssh/connectivity_utils.py |
Resolves and uses the cloud-specific registry hostname. |
src/ssh/azext_ssh/tests/latest/test_custom.py |
Updates proxy invocation assertions. |
src/ssh/azext_ssh/tests/latest/test_connectivity_utils.py |
Tests hostname resolution and proxy downloads. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az ssh arc
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.