Repository navigation
fix(aks-preview): allow longer node pool names - #10458
Merged
NoriZC merged 3 commits intoOct 15, 2026
Merged
Conversation
Contributor
|
Thank you for your contribution InduSridhar! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused validator change is consistent across affected commands and has adequate boundary coverage.
0 open findings
What changed in this PR
Raises AKS Preview’s client-side node pool name ceiling to 39 characters while delegating stricter limits to the service.
Changes:
- Updates shared validation and help text.
- Adds boundary tests for 12, 13, 39, and 40 characters.
- Documents the change in pending release history.
| File | Description |
|---|---|
src/aks-preview/HISTORY.rst |
Adds the pending release note. |
src/aks-preview/azext_aks_preview/tests/latest/test_validators.py |
Covers validation boundaries and empty names. |
src/aks-preview/azext_aks_preview/_validators.py |
Raises the maximum from 12 to 39. |
src/aks-preview/azext_aks_preview/_params.py |
Replaces fixed-limit help with naming-rule guidance. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
3 tasks done
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Karen Chen (karenychen)
approved these changes
Oct 13, 2026
FumingZhang
previously approved these changes
Oct 13, 2026
Member
|
please resolve merge conflicts InduSridhar |
FumingZhang
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Allow longer node pool names; the service enforces the actual limit. Today, aks-preview rejects names longer than 12 characters locally, including on read and delete operations. This change raises the CLI's outer ceiling to 39 while leaving pool-type and subscription-specific limits to the service.
Related command
az aks nodepool,az aks create --nodepool-name,az aks scale --nodepool-name, andaz aks machine --nodepool-name.Changes
Validation
azext_aks_preview.tests.latest.test_validatorspassed usingpython -m unittest.az aks nodepool showagainst a nonexistent resource group returnedResourceGroupNotFoundfor both 13- and 39-character names.git diff --checkpassed.The smoke tests establish that requests pass CLI validation. ARM enforcement of name-length constraints on actual pool operations and the service rejection for an overlength machines-pool name have not been independently tested. Terraform validation is outside this change.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)azdevstyle and index checks have not been run locally.