Skip to content

{CI} Supress golden gate oracledatabase cred scan - #10460

Merged
JaysonTaiMicrosoft merged 1 commit into
Azure:mainfrom
JaysonTaiMicrosoft:suppress-oracledatabase-credscan
Oct 12, 2026
Merged

JaysonTaiMicrosoft merged 1 commit into
Azure:mainfrom
JaysonTaiMicrosoft:suppress-oracledatabase-credscan

Conversation

@JaysonTaiMicrosoft

@JaysonTaiMicrosoft JaysonTaiMicrosoft commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

This checklist is used to make sure that common guidelines for a pull request are followed.

image

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The companion Golden Gate connection recording contains the same dummy credential but remains unsuppressed.

1 open finding
What changed in this PR

Updates credential-scan suppressions for Oracle Database Golden Gate test fixtures.

Changes:

  • Adds Golden Gate test and deployment recording suppressions.
  • Removes the obsolete DB-system recording suppression.
File Description
scripts/​ci/​credscan/​CredScanSuppressions.json Updates Oracle Database false-positive paths.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/ci/credscan/CredScanSuppressions.json
@JaysonTaiMicrosoft
JaysonTaiMicrosoft merged commit e1eda38 into Azure:main Oct 12, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants