{OracleDatabase} Update listPrivateIps for cloud VM cluster by mihretkidane-OCI · Pull Request #10474 · Azure/azure-cli-extensions

Mihret Kidane (mihretkidane-OCI) · 2026-10-15T17:23:13Z

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes
⚠️ None

⚠️Azure CLI Extensions Breaking Change Test

⚠️oracle-database

rule cmd_name rule_message suggest_message

⚠️ 1006 - ParaAdd oracle-database cloud-vm-cluster list-private-ip-address cmd oracle-database cloud-vm-cluster list-private-ip-address added parameter pagination_limit

⚠️ 1006 - ParaAdd oracle-database cloud-vm-cluster list-private-ip-address cmd oracle-database cloud-vm-cluster list-private-ip-address added parameter pagination_token

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Updates the private IP address list command to use API version 2026-07-01-preview, correctly deserialize the response, and return addresses from all pages as a JSON array. Adds regression coverage and bumps the extension to 3.0.1.

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-pipelines · 2026-10-15T17:23:23Z

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

Mihret Kidane (mihretkidane-OCI) · 2026-10-15T17:26:22Z

aaz PR : Azure/aaz#1127

Copilot

🟡 Changes recommended

The response envelope is not integrated with pagination or the command’s existing array output.

1 open finding

Fix address list output and fetch subsequent pages · New

What changed in this PR

Updates Oracle Database cloud VM cluster private-IP listing for the revised service response.

Changes:

Switches to API version 2026-07-01-preview.
Models the value and nextLink response envelope.
Adds a scenario test and recorded response.

File	Description
src/oracle-database/azext_oracle_database/tests/latest/test_oracle_database_private_ip_address.py	Adds the private-IP listing scenario.
src/oracle-database/azext_oracle_database/tests/latest/recordings/test_oracledatabase_cloud_vm_cluster_list_private_ip_address.yaml	Records a successful response.
src/oracle-database/azext_oracle_database/aaz/latest/oracle_database/cloud_vm_cluster/_list_private_ip_address.py	Updates the API version and response schema.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

                return cls._schema_on_200

-            cls._schema_on_200 = AAZListType()
+            cls._schema_on_200 = AAZObjectType()


x-engineering-agent · 2026-10-15T17:32:21Z

Hi Mihret Kidane (@mihretkidane-OCI),
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in pyproject.toml (or setup.py, if the extension has not migrated yet) as well.

Yong Zhang (yonzhan) · 2026-10-15T21:05:47Z

/azp run

azure-pipelines · 2026-10-15T21:06:02Z

Azure Pipelines: Successfully started running 2 pipeline(s).

Mihret Kidane (mihretkidane-OCI) · 2026-10-15T23:25:16Z

Yong Zhang (@yonzhan) please help us review this PR , we are trying to release customer fix as soon as possible . Thank you so much for your time and cooperation.

JaysonTaiMicrosoft · 2026-10-15T23:30:56Z

/azp run

azure-pipelines · 2026-10-15T23:31:08Z

Azure Pipelines: Successfully started running 2 pipeline(s).

Co-authored-by: JaysonTaiMicrosoft <jaysontai@microsoft.com>

x-engineering-agent · 2026-10-16T01:08:47Z

X Engineering Agent Report

⏳ In progress — X Engineering Agent is reviewing this PR at 3169855. This comment will be updated with the results.

Mihret Kidane (mihretkidane-OCI) · 2026-10-16T03:47:16Z

JaysonTaiMicrosoft Teresa Ritorto (@teresaritorto) I just resolved all the comments on this PR . Could you please take a look. Thanks!

JaysonTaiMicrosoft · 2026-10-16T04:06:13Z

/azp run

azure-pipelines · 2026-10-16T04:06:25Z

Azure Pipelines: Successfully started running 2 pipeline(s).

Failing CI

JaysonTaiMicrosoft · 2026-10-16T04:47:06Z

Mihret Kidane (@mihretkidane-OCI) Please sync with main. That should fix CI

Mihret Kidane (mihretkidane-OCI) · 2026-10-16T04:52:11Z

Mihret Kidane (Mihret Kidane (@mihretkidane-OCI)) Please sync with main. That should fix CI

JaysonTaiMicrosoft Done , just synched the PR . Any chance that this could be merged today?

Aditya Pujara (a0x1ab) · 2026-10-16T05:11:55Z

/azp run

azure-pipelines · 2026-10-16T05:12:08Z

Azure Pipelines: Successfully started running 2 pipeline(s).

Azure CLI Bot (azclibot) · 2026-10-16T06:17:15Z

[Release] Update index.json for extension [ oracle-database-3.0.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=186087367&view=results

list private Ips

7684ea6

Copilot AI balanced review requested due to automatic review settings October 15, 2026 17:23

Copilot started reviewing on behalf of Mihret Kidane (mihretkidane-OCI) October 15, 2026 17:23

View session

Mihret Kidane (mihretkidane-OCI) mentioned this pull request Oct 15, 2026

oracle database listPrivateIps and other missing metadata Azure/aaz#1127

Merged

Copilot AI reviewed Oct 15, 2026

View reviewed changes

Comment thread ...zext_oracle_database/aaz/latest/oracle_database/cloud_vm_cluster/_list_private_ip_address.py

return cls._schema_on_200

cls._schema_on_200 = AAZListType()

cls._schema_on_200 = AAZObjectType()

x-engineering-agent Bot added this to the November 2026 (2026-11-03) milestone Oct 15, 2026

Yong Zhang (yonzhan) requested a review from JaysonTaiMicrosoft October 15, 2026 21:06

Yong Zhang (yonzhan) assigned JaysonTaiMicrosoft Oct 15, 2026

Mihret Kidane (mihretkidane-OCI) added 2 commits October 15, 2026 16:35

fix version

4eb27dc

comment resolution

87c94df

Teresa Ritorto (teresaritorto) added the Request X Engineering Agent Ask the agent to triage this issue or review this PR label Oct 15, 2026

JaysonTaiMicrosoft reviewed Oct 15, 2026

View reviewed changes

Comment thread src/oracle-database/HISTORY.rst Outdated

Update src/oracle-database/HISTORY.rst

cc2aff6

Co-authored-by: JaysonTaiMicrosoft <jaysontai@microsoft.com>

JaysonTaiMicrosoft previously approved these changes Oct 16, 2026

View reviewed changes

JaysonTaiMicrosoft changed the title ~~Update listPrivateIps for cloud VM cluster~~ {OracleDatabase} Update listPrivateIps for cloud VM cluster Oct 16, 2026

Merge branch 'refs/heads/main' into list-privateIps

3169855

JaysonTaiMicrosoft approved these changes Oct 16, 2026

View reviewed changes

JaysonTaiMicrosoft merged commit 08772c4 into Azure:main Oct 16, 2026
24 checks passed

rule	cmd_name	rule_message	suggest_message
⚠️ 1006 - ParaAdd	oracle-database cloud-vm-cluster list-private-ip-address	cmd `oracle-database cloud-vm-cluster list-private-ip-address` added parameter `pagination_limit`
⚠️ 1006 - ParaAdd	oracle-database cloud-vm-cluster list-private-ip-address	cmd `oracle-database cloud-vm-cluster list-private-ip-address` added parameter `pagination_token`

Conversation

Mihret Kidane (mihretkidane-OCI) commented Oct 15, 2026 • edited by x-engineering-agent Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 PR Validation — ⚠️ Review suggested

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-pipelines Bot commented Oct 15, 2026

Uh oh!

Mihret Kidane (mihretkidane-OCI) commented Oct 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

x-engineering-agent Bot commented Oct 15, 2026

Uh oh!

Yong Zhang (yonzhan) commented Oct 15, 2026

Uh oh!

azure-pipelines Bot commented Oct 15, 2026

Uh oh!

Mihret Kidane (mihretkidane-OCI) commented Oct 15, 2026

Uh oh!

JaysonTaiMicrosoft commented Oct 15, 2026

Uh oh!

azure-pipelines Bot commented Oct 15, 2026

Uh oh!

Uh oh!

x-engineering-agent Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

X Engineering Agent Report

Uh oh!

Mihret Kidane (mihretkidane-OCI) commented Oct 16, 2026

Uh oh!

JaysonTaiMicrosoft commented Oct 16, 2026

Uh oh!

azure-pipelines Bot commented Oct 16, 2026

Uh oh!

JaysonTaiMicrosoft commented Oct 16, 2026

Uh oh!

Mihret Kidane (mihretkidane-OCI) commented Oct 16, 2026

Uh oh!

Aditya Pujara (a0x1ab) commented Oct 16, 2026

Uh oh!

azure-pipelines Bot commented Oct 16, 2026

Uh oh!

Uh oh!

Azure CLI Bot (azclibot) commented Oct 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Mihret Kidane (mihretkidane-OCI) commented Oct 15, 2026 •

edited by x-engineering-agent Bot

Loading

x-engineering-agent Bot commented Oct 16, 2026 •

edited

Loading