-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[AKS] Add --enable-opentelemetry-metrics and --enable-opentelemetry-logs to monitoring addons in aks-preview #9149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
aks create | cmd aks create added parameter disable_opentelemetry_logs |
||
aks create | cmd aks create added parameter disable_opentelemetry_metrics |
||
aks create | cmd aks create added parameter enable_opentelemetry_logs |
||
aks create | cmd aks create added parameter enable_opentelemetry_metrics |
||
aks create | cmd aks create added parameter opentelemetry_logs_port |
||
aks create | cmd aks create added parameter opentelemetry_metrics_port |
||
aks update | cmd aks update added parameter disable_opentelemetry_logs |
||
aks update | cmd aks update added parameter disable_opentelemetry_metrics |
||
aks update | cmd aks update added parameter enable_opentelemetry_logs |
||
aks update | cmd aks update added parameter enable_opentelemetry_metrics |
||
aks update | cmd aks update added parameter opentelemetry_logs_port |
||
aks update | cmd aks update added parameter opentelemetry_metrics_port |
Hi @gracewehner, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds OpenTelemetry metrics and logs configuration support to the aks-preview extension. The changes enable users to configure OpenTelemetry endpoints with custom ports for both metrics and logs collection, requiring Azure Monitor as a prerequisite.
Key changes:
- Added new CLI parameters for enabling/disabling OpenTelemetry metrics and logs
- Implemented port validation and dependency checking
- Extended managed cluster decorator to handle OpenTelemetry configuration
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
setup.py | Version bump to 18.0.0b37 |
test_validators.py | Added comprehensive test coverage for OpenTelemetry validation functions |
test_opentelemetry_integration.py | New integration test file for end-to-end OpenTelemetry functionality |
test_managed_cluster_decorator.py | Added tests for OpenTelemetry parameter handling in decorators |
managed_cluster_decorator.py | Core implementation of OpenTelemetry configuration logic |
custom.py | Added OpenTelemetry parameters to function signatures |
_validators.py | Implemented validation functions for OpenTelemetry configurations |
_params.py | Added CLI parameter definitions and validation hooks |
_help.py | Added help documentation for new OpenTelemetry parameters |
|
Please fix CI issues |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add some scenario test cases to test_aks_commands.py to help verify your change?
/azp run |
Commenter does not have sufficient privileges for PR 9149 in repo Azure/azure-cli-extensions |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
) | ||
return enable_opentelemetry_logs | ||
|
||
def get_enable_opentelemetry_logs(self) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logs_and_traces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep consistent with profile, doc for traces
/azp run |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.