Skip to content

Conversation

DomAyre
Copy link

@DomAyre DomAyre commented Sep 17, 2025

Why

There is a test for the confcom extension which pulls a docker image by tag, and then asserts layer hashes match, this breaks regularly because the image changes between invocations.

This PR fixes that test

How

  • Update the expected layer hashes to match what we get now
  • Update the image reference and the code which pulls the image to ask for a specific image sha, this should prevent the layer hashes changing under us again

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az confcom

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Copilot Copilot AI review requested due to automatic review settings September 17, 2025 16:47
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

Copy link

Hi @DomAyre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a flaky test in the confcom extension that was failing due to Docker image layer hashes changing when the image was updated. The fix ensures test stability by pinning to a specific image SHA instead of relying on a mutable tag.

  • Updated the container image reference to use a specific SHA256 digest instead of a tag
  • Modified the image pulling logic to use the full container image reference
  • Updated the expected layer hashes to match the pinned image

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 17, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link

@DomAyre
Copy link
Author

DomAyre commented Sep 18, 2025

Since this is a test fix, no changes in HISTORY.rst or bump to version is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants