Skip to content

Conversation

bavneetsingh16
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Copilot Copilot AI review requested due to automatic review settings September 18, 2025 00:13
Copy link

azure-client-tools-bot-prd bot commented Sep 18, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @bavneetsingh16,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 18, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Connected Kubernetes (connectedk8s) CLI extension to version 1.10.9. The main purpose is to update the underlying SDK to use the new preview API version "2025-08-01-preview" and modernize the generated client code to use the latest Azure SDK code generation patterns.

  • Version bump from 1.10.8 to 1.10.9 in setup.py
  • Migration from AutoRest to Python Code Generator for SDK generation
  • Update to API version "2025-08-01-preview"

Reviewed Changes

Copilot reviewed 40 out of 41 changed files in this pull request and generated no comments.

Show a summary per file
File Description
setup.py Version number updated from 1.10.8 to 1.10.9
operations/_operations.py Complete rewrite using Python Code Generator with new API structure and method signatures
operations/__init__.py Updated imports and module structure for new code generation pattern
models/_models.py New comprehensive model definitions for the 2025-08-01-preview API
models/_enums.py Updated enums with new ActionType and Origin types, expanded ConnectivityStatus
models/__init__.py Complete rewrite of model exports matching new generation pattern
aio/ directory Async client implementations updated to match new patterns
_utils/serialization.py Modernized serialization utilities with improved error handling and type hints

@bavneetsingh16
Copy link
Contributor Author

We have set up live tests in our forked repository as a continuous integration (CI) check and those tests include coverage for all these changes. All the tests can be found here:
https://github.com/AzureArcForKubernetes/connectedk8s/blob/main/testing/test/configurations

As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite

Copy link

@zhoxing-ms zhoxing-ms merged commit d4d58b1 into Azure:main Sep 19, 2025
35 of 39 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ connectedk8s-1.10.9 ] : https://dev.azure.com/msazure/One/_build/results?buildId=137602188&view=results

@bavneetsingh16 bavneetsingh16 deleted the release-v1.10.9 branch September 19, 2025 16:42
@bavneetsingh16 bavneetsingh16 restored the release-v1.10.9 branch September 19, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants