Repository navigation
az aks prepared-image-specification - #9887
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi Jim Minter (@jim-minter), |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Release SuggestionsModule: aks-preview
Notes
|
1 similar comment
Release SuggestionsModule: aks-preview
Notes
|
82b1950 to
9807b5e
Compare
75d537f to
f4e6f6c
Compare
95e4759 to
9ede666
Compare
9ede666 to
93b1e15
Compare
|
Why does the user need to run this command: az provider register -n Microsoft.ContainerService --wait That shouldn't be necessary for PIS. |
2a2b32f to
111cfcd
Compare
There was a problem hiding this comment.
Copilot encountered an error: Your billing is not configured or you have Copilot licenses from multiple standalone organizations or enterprises. To use premium requests, select a billing entity via the GitHub site, under Settings > Copilot > Features.
Tim Wright (@timmy-wright) This is only necessary until the feature flag is lifted, for use in subscriptions which do not yet have the feature flag set. |
|
Yong Zhang (@yonzhan) Julie Zhu (@yanzhudd) Tim Wright (@timmy-wright) FumingZhang this should be ready for review now, ptal? |
|
When a PIS references a managed identity, the CLI grants the cluster identity the Managed Identity Operator role on it. But this only happens for create and nodepool add:
So aks_agentpool_update should call ensure_pis_managed_identity_permission_for_agentpool too, to match add and create. |
Thanks Shun Lyu (@sinmentis) ! Should be fixed now! |
Ben Brady (benjamin-brady)
left a comment
There was a problem hiding this comment.
LGTM. This aligns with the api-specs for prepared image specification which is currently at 2026-02-02-preview. I've confirmed the postScriptAction field is in place which was my main concern.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
(generated using `tsp compile . --emit=@azure-tools/typespec-python`)
4160b88 to
9041cd8
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9887 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Xing Zhou (@zhoxing-ms) , Julie Zhu (@yanzhudd) or Yong Zhang (@yonzhan) , please merge :-) |
az aks prepared-image-specification
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks prepared-image-specification
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.