Repository navigation
{AKS} az aks maintenancewindow: Add CRUD commands for peer MaintenanceWindow resources #9927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Julie Zhu (yanzhudd)
merged 6 commits into
Azure:main
from
ibaboulfetouh:iaboulfetouh/aks-preview-maintenancewindow
Jun 23, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fb335a8
{AKS} az aks maintenancewindow: Add CRUD commands for peer Maintenanc…
954cd36
{AKS} maintenancewindow: drop refetch/merge in update; honor PATCH-or…
c05c144
{AKS} az aks maintenancewindow: address iter-2 review (Anushka + Ye)
879a175
{AKS} az aks maintenancewindow: add E2E scenario test; fix help lint;…
4b772f5
{AKS} restore test_aks_maintenancewindow.yaml recording
a4327f2
Merge remote-tracking branch 'upstream/main' into iaboulfetouh/aks-pr…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double confirmation on delete
The command is registered with confirmation=True and the handler manually calls prompt_y_n. Users will be prompted twice. We should pick one way to confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.
confirmation=Truein commands.py registration gives users a uniform--yesflag handled by the CLI core (which honorsAZURE_CORE_DISABLE_CONFIRM_PROMPTand--yesconsistently with every other AKS delete), while the handler-sideprompt_y_nis hand-rolled. Drop the handler-side prompt and rely onconfirmation=True— theyesparameter on the handler can also go away then.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in fc075fb. Kept
confirmation=Trueon the command registration (auto-injects--yes/-yvia CLI core, respectsAZURE_CORE_DISABLE_CONFIRM_PROMPT), dropped the handler-sideprompt_y_nand theyeskwarg. Matchesaks delete/aks nodepool delete. Verified withaz aks maintenancewindow delete --help— single--yes -yarg now.