Skip to content

[HORIZONDB] az horizondb update: Add new command to update Horizon DB resource - #9928

Merged
Yu Chen (jsntcy) merged 5 commits into
Azure:mainfrom
nasc17:nasc/horizonUpdateCommand
Jun 13, 2026
Merged

Yu Chen (jsntcy) merged 5 commits into
Azure:mainfrom
nasc17:nasc/horizonUpdateCommand

Conversation

@nasc17

@nasc17 nasc17 commented Jun 10, 2026

Copy link
Copy Markdown
Member

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az horizondb update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 10, 2026 23:25
@azure-client-tools-bot-prd

azure-client-tools-bot-prd Bot commented Jun 10, 2026 •

Copy link
Copy Markdown
⚠️Azure CLI Extensions Breaking Change Test
⚠️horizondb
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd horizondb update cmd horizondb update added

@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi nasc17,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds support for updating an existing HorizonDB cluster via a new az horizondb update command, including CLI parameters, help text, and a basic scenario test.

Changes:

  • Register horizondb update command and wire it to a new custom implementation.
  • Add CLI arguments and help content for update (tags, admin password, v-cores).
  • Extend the existing command scenario test to cover updating vCores.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/horizondb/azext_horizondb/tests/latest/test_horizondb_commands.py Adds a scenario assertion for the new horizondb update command
src/horizondb/azext_horizondb/commands/custom_commands.py Implements horizondb_cluster_update and adjusts error type usage
src/horizondb/azext_horizondb/cluster_commands.py Registers the new update custom command
src/horizondb/azext_horizondb/_params.py Defines new аргuments for horizondb update
src/horizondb/azext_horizondb/_help.py Adds help entry and an example for horizondb update

Comment thread src/horizondb/azext_horizondb/commands/custom_commands.py Outdated
Comment thread src/horizondb/azext_horizondb/commands/custom_commands.py
Comment thread src/horizondb/azext_horizondb/commands/custom_commands.py Outdated
@yonzhan

Copy link
Copy Markdown
Collaborator

horizondb

@jsntcy
Yu Chen (jsntcy) requested review from a team and removed request for a team June 12, 2026 00:12
@jsntcy Yu Chen (jsntcy) removed their assignment Jun 12, 2026
@jsntcy
Yu Chen (jsntcy) requested a review from a team June 12, 2026 04:37
@nasc17

nasc17 commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

Yu Chen (@jsntcy) Yong Zhang (@yonzhan) can we please this PR merged :-)

@jsntcy

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@jsntcy
Yu Chen (jsntcy) merged commit 70c9cf9 into Azure:main Jun 13, 2026
24 checks passed
@azclibot

Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ horizondb-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=167885795&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants