Repository navigation
[HORIZONDB] az horizondb update: Add new command to update Horizon DB resource - #9928
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| horizondb update | cmd horizondb update added |
|
Hi nasc17, |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for updating an existing HorizonDB cluster via a new az horizondb update command, including CLI parameters, help text, and a basic scenario test.
Changes:
- Register
horizondb updatecommand and wire it to a new custom implementation. - Add CLI arguments and help content for update (tags, admin password, v-cores).
- Extend the existing command scenario test to cover updating vCores.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/horizondb/azext_horizondb/tests/latest/test_horizondb_commands.py | Adds a scenario assertion for the new horizondb update command |
| src/horizondb/azext_horizondb/commands/custom_commands.py | Implements horizondb_cluster_update and adjusts error type usage |
| src/horizondb/azext_horizondb/cluster_commands.py | Registers the new update custom command |
| src/horizondb/azext_horizondb/_params.py | Defines new аргuments for horizondb update |
| src/horizondb/azext_horizondb/_help.py | Adds help entry and an example for horizondb update |
|
horizondb |
|
Yu Chen (@jsntcy) Yong Zhang (@yonzhan) can we please this PR merged :-) |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ horizondb-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=167885795&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az horizondb updateGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.