Repository navigation
{Core} Add arm_tools.py - #29973
Draft
Jiashuo Li (jiasli) wants to merge 3 commits into
Draft
{Core} Add arm_tools.py#29973Jiashuo Li (jiasli) wants to merge 3 commits into
arm_tools.py#29973Jiashuo Li (jiasli) wants to merge 3 commits into
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Core |
microsoft-github-policy-service
Bot
requested a review
from Yong Zhang (yonzhan)
September 25, 2024 09:17
microsoft-github-policy-service
Bot
added
Auto-Assign
3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
parse_resource_id,is_valid_resource_id,resource_idwere initially frommsrestazure.tools. They were later migrated toazure.mgmt.core.tools.This PR puts them in
azure.cli.core.arm_toolsso that command modules take no direct dependency onazure.mgmt.core.tools.For now, this
azure.cli.core.arm_toolsis a proxy toazure.mgmt.core.tools. If there is a Track 3 SDK in the future, the migration would also be easier.As Azure CLI is moving towards decoupling from SDK, CLI should eventually provide its own implementations.