{RDBMS} az postgres flexible-server firewall-rule: Update validations and message for fire wall rule commands
#30780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
nasc17
requested review from
mattboentoro and
nachoalonsoportillo
and removed request for
yonzhan
mattboentoro
approved these changes
Feb 7, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
evelyn-ys
previously approved these changes
Feb 7, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
evelyn-ys
approved these changes
Feb 13, 2025
|
lgtm |
|
@evelyn-ys can this be merged in |
|
@calvinhzy can this please be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az postgres flexible-server firewall-rule
Description
az postgres flexible-server firewall-rule create needs to validate that either --start-ip-address or --end-ip-address are passed. Otherwise, it constructs a request with an empty body that returns an InternalServerError.''
Change the text of this error, to the following:
Firewall rule operations cannot be requested for a server that doesn't have public access enabled.
Testing Guide
Manual
Validate stat or end has to be passed
Update error text
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.