[Role] az role assignment list: Include role assignments inherited from management groups
#30841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
evelyn-ys,
calvinhzy and
bebound
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @jiasli, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
jiasli
changed the title
az role assignment list: Include role assignments inherited from management groupsaz role assignment list: Include role assignments inherited from management groups
evelyn-ys
approved these changes
Feb 21, 2025
jiasli
commented
Feb 21, 2025
| @@ -578,7 +578,7 @@ def _search_role_assignments(cli_ctx, assignments_client, definitions_client, | |||
| # "atScope()" and "principalId eq '{value}'" query cannot be used together (API limitation). | |||
| # always use "scope" if provided, so we can get assignments beyond subscription e.g. management groups | |||
| if scope: | |||
| f = 'atScope()' | |||
| f = 'atScope()' # atScope() excludes role assignments at subscopes | |||
There was a problem hiding this comment.
More discussion on this enforced atScope(): #14302
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az role assignment listDescription
Fix #25078
Currently
--include-inheritedonly works for "normal" Azure resource ID, up to tenant level, such asThis reason is explained in #25078 (comment).
This PR includes role assignments inherited from management groups:
Testing Guide
The result will now include role assignments like: