Repository navigation
{Network} NAT Gateway and Public IP StandardV2 sku scenario tests - #32055
Merged
Ethan Yang (necusjz) merged 1 commit intoSep 5, 2025
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
Yu Chen (jsntcy),
kai ru (kairu-ms) and
Yong Zhang (yonzhan)
September 4, 2025 07:50
Ethan Yang (necusjz)
marked this pull request as ready for review
September 5, 2025 00:26
Ethan Yang (necusjz)
requested review from
Ethan Yang (necusjz) and
ZelinWang (wangzelin007)
as code owners
September 5, 2025 00:26
Ethan Yang (necusjz)
approved these changes
Sep 5, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds scenario tests for NAT Gateway and Public IP with StandardV2 SKU support, enabling comprehensive testing of the new StandardV2 capability introduced in a related PR.
- Adds test coverage for StandardV2 SKU for NAT Gateway creation and verification
- Extends Public IP tests to include StandardV2 SKU creation and validation
- Updates Public IP prefix creation to include required IP tags for consistency
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py |
Adds test case for creating Public IP with StandardV2 SKU |
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_natgateway_commands.py |
Adds NAT Gateway StandardV2 SKU test and updates IP prefix creation with IP tags |
src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_network_public_ip_sku.yaml |
Test recording file updated to include new StandardV2 test execution data |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az network nat gateway createaz network public-ip createDescription
Scenario tests based on #32050
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.