Skip to content

[Storage] Fix #32048: az storage blob sync: Fix using azcopy with account-key without login into azcli #32127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zhiyi Huang (calvinhzy) merged 2 commits into from
Sep 22, 2025
Merged

[Storage] Fix #32048: az storage blob sync: Fix using azcopy with account-key without login into azcli #32127

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbc2732
fix case where user is not logged in but want to use azcopy with acco…
calvinhzy Sep 16, 2025
510db56
check other cases like if sas-token is passed in or account-key is pa…
calvinhzy Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/storage/azcopy/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ def login_auth_for_azcopy(cmd):


def client_auth_for_azcopy(cmd, client):
# prefer oauth mode
if client.credential:
# prefer oauth mode, if account-key is not provided
if client.credential and not hasattr(client.credential, "account_key"):

@evelyn-ys Yishi Wang (evelyn-ys) Sep 17, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that client.credential is just a dict containing account_key so that hasattr() won't work?

Or is it possible that credential has sth else, eg SAS token or connection string so that no OAuth is needed?

@calvinhzy Zhiyi Huang (calvinhzy) Sep 22, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more cases

raw_token = Profile(cli_ctx=cmd.cli_ctx).get_raw_token(resource=STORAGE_RESOURCE_ENDPOINT)
token_info = raw_token[0][2]
try:
Expand Down