Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/azure-cli/azure/cli/command_modules/storage/_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,9 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem
c.argument('account_name', acct_name_type, options_list=['--name', '-n'], local_context_attribute=None)

with self.argument_context('storage account create', resource_type=ResourceType.MGMT_STORAGE) as c:
t_account_type, t_sku_name, t_kind, t_tls_version, t_dns_endpoint_type = \
t_account_type, t_sku_name, t_kind, t_tls_version, t_dns_endpoint_type, t_zone_placement_policy = \
self.get_models('AccountType', 'SkuName', 'Kind', 'MinimumTlsVersion', 'DnsEndpointType',
'ZonePlacementPolicy',
resource_type=ResourceType.MGMT_STORAGE)
Comment on lines +325 to 328

Copilot AI Sep 29, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The tuple unpacking on line 325 is getting very long with 6 variables. Consider breaking this into multiple lines or using separate get_models calls for better readability and maintainability.

Suggested change
t_account_type, t_sku_name, t_kind, t_tls_version, t_dns_endpoint_type, t_zone_placement_policy = \
self.get_models('AccountType', 'SkuName', 'Kind', 'MinimumTlsVersion', 'DnsEndpointType',
'ZonePlacementPolicy',
resource_type=ResourceType.MGMT_STORAGE)
t_account_type = self.get_models('AccountType', resource_type=ResourceType.MGMT_STORAGE)
t_sku_name = self.get_models('SkuName', resource_type=ResourceType.MGMT_STORAGE)
t_kind = self.get_models('Kind', resource_type=ResourceType.MGMT_STORAGE)
t_tls_version = self.get_models('MinimumTlsVersion', resource_type=ResourceType.MGMT_STORAGE)
t_dns_endpoint_type = self.get_models('DnsEndpointType', resource_type=ResourceType.MGMT_STORAGE)
t_zone_placement_policy = self.get_models('ZonePlacementPolicy', resource_type=ResourceType.MGMT_STORAGE)

Copilot uses AI. Check for mistakes.
t_identity_type = self.get_models('IdentityType', resource_type=ResourceType.MGMT_STORAGE)
c.register_common_storage_account_options()
Expand Down Expand Up @@ -436,6 +437,10 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem
arg_group='Azure Files Identity Based Authentication',
help='Specifies if managed identities can access SMB shares using OAuth. '
'The default interpretation is false for this property.')
c.argument('zones', nargs='+',
help='Describes the available zones for the product where storage account resource can be created.')
c.argument('zone_placement_policy', arg_type=get_enum_type(t_zone_placement_policy),
help='The availability zone pinning policy for the storage account.')

with self.argument_context('storage account private-endpoint-connection',
resource_type=ResourceType.MGMT_STORAGE) as c:
Expand Down Expand Up @@ -530,6 +535,10 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem
c.argument('enable_smb_oauth', arg_type=get_three_state_flag(),
arg_group='Azure Files Identity Based Authentication',
help='Specifies if managed identities can access SMB shares using OAuth. ')
c.argument('zones', nargs='+',
help='Describes the available zones for the product where storage account resource can be created.')
Comment on lines +538 to +539

Copilot AI Sep 29, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help text for 'zones' is duplicated between create and update contexts (lines 440-441 and 538-539). Consider extracting this to a constant to avoid duplication and ensure consistency.

Copilot uses AI. Check for mistakes.
c.argument('zone_placement_policy', arg_type=get_enum_type(t_zone_placement_policy),
help='The availability zone pinning policy for the storage account.')
Comment on lines +540 to +541

Copilot AI Sep 29, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help text for 'zones' is duplicated between create and update contexts (lines 440-441 and 538-539). Consider extracting this to a constant to avoid duplication and ensure consistency.

Copilot uses AI. Check for mistakes.

for scope in ['storage account create', 'storage account update']:
with self.argument_context(scope, arg_group='Customer managed key',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def create_storage_account(cmd, resource_group_name, account_name, sku=None, loc
enable_nfs_v3=None, subnet=None, vnet_name=None, action='Allow', enable_alw=None,
immutability_period_since_creation_in_days=None, immutability_policy_state=None,
allow_protected_append_writes=None, public_network_access=None, dns_endpoint_type=None,
enable_smb_oauth=None):
enable_smb_oauth=None, zones=None, zone_placement_policy=None):
StorageAccountCreateParameters, Kind, Sku, CustomDomain, AccessTier, Identity, Encryption, NetworkRuleSet = \
cmd.get_models('StorageAccountCreateParameters', 'Kind', 'Sku', 'CustomDomain', 'AccessTier', 'Identity',
'Encryption', 'NetworkRuleSet')
Expand Down Expand Up @@ -313,6 +313,13 @@ def create_storage_account(cmd, resource_group_name, account_name, sku=None, loc
if dns_endpoint_type is not None:
params.dns_endpoint_type = dns_endpoint_type

if zones is not None:
params.zones = zones

if zone_placement_policy is not None:
Placement = cmd.get_models('Placement')
params.placement = Placement(zone_placement_policy=zone_placement_policy)

return scf.storage_accounts.begin_create(resource_group_name, account_name, params)


Expand Down Expand Up @@ -407,7 +414,7 @@ def update_storage_account(cmd, instance, sku=None, tags=None, custom_domain=Non
allow_cross_tenant_replication=None, default_share_permission=None,
immutability_period_since_creation_in_days=None, immutability_policy_state=None,
allow_protected_append_writes=None, public_network_access=None, upgrade_to_storagev2=None,
yes=None, enable_smb_oauth=None):
yes=None, enable_smb_oauth=None, zones=None, zone_placement_policy=None):
StorageAccountUpdateParameters, Sku, CustomDomain, AccessTier, Identity, Encryption, NetworkRuleSet, Kind = \
cmd.get_models('StorageAccountUpdateParameters', 'Sku', 'CustomDomain', 'AccessTier', 'Identity', 'Encryption',
'NetworkRuleSet', 'Kind')
Expand Down Expand Up @@ -710,6 +717,13 @@ def update_storage_account(cmd, instance, sku=None, tags=None, custom_domain=Non
if enable_local_user is not None:
params.is_local_user_enabled = enable_local_user

if zones is not None:
params.zones = zones

if zone_placement_policy is not None:
Placement = cmd.get_models('Placement')
params.placement = Placement(zone_placement_policy=zone_placement_policy)

return params


Expand Down
Loading