Repository navigation
{Misc.} Add devcontainer environment variables - #32195
Merged
Merged
Conversation
Ethan Yang (necusjz)
requested review from
Aditya Pujara (a0x1ab) and
Julie Zhu (yanzhudd)
September 30, 2025 00:05
️✔️AzureCLI-FullTest
|
|
Hi Ethan Yang (@necusjz), |
️✔️AzureCLI-BreakingChangeTest
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the aaz-dev launch command in the devcontainer environment by adding environment variables to configure the required paths automatically, eliminating the need for manual command-line parameters.
Key changes:
- Added environment variables configuration for aaz-dev tool paths
- Simplified launch instructions by removing explicit path parameters
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .devcontainer/.env | New file defining environment variables for aaz-dev tool paths |
| .devcontainer/devcontainer.json | Added runArgs to load environment variables from .env file |
| .devcontainer/init.sh | Updated launch instructions to use simplified aaz-dev run command |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Aditya Pujara (a0x1ab)
approved these changes
Sep 30, 2025
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
simplify the launch command of aaz (mcp server can also leverage them).
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.