Repository navigation
[SQL] Support versionless key in server key, server encryption protector and database create/update - #32225
Closed
Simon Zhang (simonzhang0428) wants to merge 3 commits into
Closed
[SQL] Support versionless key in server key, server encryption protector and database create/update#32225Simon Zhang (simonzhang0428) wants to merge 3 commits into
Simon Zhang (simonzhang0428) wants to merge 3 commits into
Conversation
(cherry picked from commit 4fbb6af)
Simon Zhang (simonzhang0428)
requested a review
from Yishi Wang (evelyn-ys)
as a code owner
October 7, 2025 19:17
Simon Zhang (simonzhang0428)
requested a review
from Zhiyi Huang (calvinhzy)
as a code owner
October 7, 2025 19:17
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested a review
from Yong Zhang (yonzhan)
October 7, 2025 19:17
microsoft-github-policy-service
Bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for versionless key URIs in SQL server key operations and database create/update commands. This enhances Azure CLI's SQL module to handle Azure Key Vault keys without explicit version identifiers.
- Updated regex pattern to accept both versioned and versionless key URIs
- Modified key name generation logic to handle versionless keys with a different naming format
- Updated error messages to include examples of both versioned and versionless key formats
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
Pls add related tests as described in PR description |
Contributor
|
Hi Simon Zhang (@simonzhang0428), Let me know if you will still work on this PR |
Yishi Wang (evelyn-ys)
modified the milestones:
November 2025 (2025-11-04),
November 2025 (2025-11-18)❗ Breaking change release ❗
Author
|
This task is paused, please ignore the PR, sorry for the late response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az sql server key create
az sql server tde-key set
az sql db create
az sql db update
Description
SQL already made Management Service change to support versionless key as parameter, including the scenarios like add versionless key into server, set it as server Encryption Protector, create/update database when supply it as keys or encryption protector.
Testing Guide
Will add test cases in SqlServerDbMgmtScenarioTest module to cover support scenarios
History Notes
[SQL]
az sql server key create: Support versionless key uri in--kidparameter[SQL]
az sql server tde-key set: Support versionless key uri in--kidparameter[SQL]
az sql db create/update: Support versionless key uri in--keys,--encryption-protectorparametersThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.