Repository navigation
{ACS} az aks create: Revert the changes to make --no-ssh-key default behaviour - #32231
Merged
Merged
Conversation
Aditya Pujara (a0x1ab)
requested a review
from Xing Zhou (zhoxing-ms)
as a code owner
October 9, 2025 02:28
Aditya Pujara (a0x1ab)
requested review from
FumingZhang,
Yu Chen (jsntcy) and
Julie Zhu (yanzhudd)
as code owners
October 9, 2025 02:28
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes that made --no-ssh-key the default behavior for az aks create commands. The revert restores the previous SSH key validation logic and removes associated test coverage that was added to validate the new default behavior.
- Reverts SSH key validation to require explicit SSH key provision or generation
- Removes test case that validated the no-SSH-key default behavior
- Updates help documentation to remove references to the new default behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test_aks_commands.py | Removes the test_aks_create_no_ssh_key test method and its associated test recording |
| test_aks_create_no_ssh_key.yaml | Removes the entire test recording file for the no-SSH-key test case |
| _validators.py | Reverts SSH key validation logic to raise an error instead of defaulting to no-SSH-key |
| _help.py | Updates help text to remove references to the new default no-SSH-key behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Xing Zhou (zhoxing-ms)
approved these changes
Oct 9, 2025
Aditya Pujara (a0x1ab)
changed the title
az aks create: Make --no-ssh-key default behaviour"az aks create: Revert the changes to make --no-ssh-key default behaviour
Aditya Pujara (a0x1ab)
changed the title
az aks create: Revert the changes to make --no-ssh-key default behaviouraz aks create: Revert the changes to make --no-ssh-key default behaviour
ZelinWang (wangzelin007)
approved these changes
Oct 9, 2025
microsoft-github-policy-service
Bot
requested review from
Yong Zhang (yonzhan) and
Xing Zhou (zhoxing-ms)
October 9, 2025 02:35
microsoft-github-policy-service
Bot
added
Auto-Assign
FumingZhang
approved these changes
Oct 9, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
The PR description is incorrect. #32115 is the reverted PR. |
Jiashuo Li (jiasli)
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #32115
[Breaking change to be released in the following iteration]