Repository navigation
{RDBMS} Add auto-tuning command group to support all recommendation types for automated tuning & deprecate index-tuning - #32353
Conversation
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This pull request renames the "index-tuning" feature to "automated-tuning" to better reflect its expanded scope, which now includes both index and table tuning recommendations. The change is a comprehensive refactoring that updates command names, function names, variable names, documentation, and help text across the codebase.
- Renamed CLI command group from
index-tuningtoautomated-tuning - Renamed
list-recommendationscommand tolist-index-recommendationsand added newlist-table-recommendationscommand - Updated all function names, variable names, and documentation to use "automated tuning" terminology
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test_rdbms_flexible_commands.py | Updated test commands to use the new automated-tuning command group and separated index/table recommendation commands |
| flexible_server_custom_postgres.py | Renamed functions from index_tuning_* to automated_tuning_*, added table_recommendations_list function, and updated error/log messages |
| flexible_server_commands.py | Updated command group registration from index-tuning to automated-tuning and split recommendation commands |
| _util.py | Renamed function from get_index_tuning_settings_map to get_automated_tuning_settings_map |
| _params.py | Updated parameter definitions to use tuning context string instead of index-tuning, renamed parameter from index_tuning_enabled to tuning_enabled |
| _helptext_pg.py | Updated all help text entries from index-tuning to tuning and expanded descriptions to mention both index and table tuning |
| _flexible_server_location_capabilities_util.py | Renamed variable from index_tuning to automated_tuning for consistency |
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/rdbms/_flexible_server_location_capabilities_util.py:114
- The dictionary key 'index_tuning_supported' should be renamed to 'automated_tuning_supported' to be consistent with the renamed variable and the overall renaming from 'index tuning' to 'automated tuning' throughout the codebase.
'index_tuning_supported': index_tuning_supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… and tests for PostgreSQL flexible server commands
…ers, and command groups for consistency
…into nacho/automated-tuning
… and help texts for PostgreSQL flexible server
…ity checks for PostgreSQL flexible server
… in flexible server auto-tuning command
…soportillo/azure-cli into nacho/automated-tuning
|
Please fix CI issues |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
Nacho Alonso Portillo (@nachoalonsoportillo) Please resolve conflicts and fix CI failure |
Related command
az postgres flexible-server index-tuningaz postgres flexible-server auto-tuningDescription
Introduce a new command group that extends the scope of index tuning to also cover other types of recommendations.
Testing Guide
A new test class was added to test all commands of the new
az postgres flexible-server auto-tuningcommand group.History Notes
[Component Name 1]
az postgres flexible-server index-tuning: This command group is announced as deprecated and user is redirected to newaz postgres flexible-server auto-tuningcommand group.[Component Name 2]
az postgres flexible-server auto-tuning: Supports listing index recommendations vialist-index-recommendationscommand and table recommendations vialist-table-recommendationscommand.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.