Skip to content

{RDBMS} Add auto-tuning command group to support all recommendation types for automated tuning & deprecate index-tuning - #32353

Closed
Nacho Alonso Portillo (nachoalonsoportillo) wants to merge 11 commits into
Azure:devfrom
nachoalonsoportillo:nacho/automated-tuning
Closed

Nacho Alonso Portillo (nachoalonsoportillo) wants to merge 11 commits into
Azure:devfrom
nachoalonsoportillo:nacho/automated-tuning

Conversation

@nachoalonsoportillo

@nachoalonsoportillo Nacho Alonso Portillo (nachoalonsoportillo) commented Oct 29, 2025 •

Copy link
Copy Markdown
Member

Related command
az postgres flexible-server index-tuning
az postgres flexible-server auto-tuning

Description
Introduce a new command group that extends the scope of index tuning to also cover other types of recommendations.

Testing Guide
A new test class was added to test all commands of the new az postgres flexible-server auto-tuning command group.

History Notes

[Component Name 1] az postgres flexible-server index-tuning: This command group is announced as deprecated and user is redirected to new az postgres flexible-server auto-tuning command group.
[Component Name 2] az postgres flexible-server auto-tuning: Supports listing index recommendations via list-index-recommendations command and table recommendations via list-table-recommendations command.


This checklist is used to make sure that common guidelines for a pull request are followed.

@azure-client-tools-bot-prd

Copy link
Copy Markdown
Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd

Copy link
Copy Markdown
Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan

Copy link
Copy Markdown
Collaborator

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions

Copy link
Copy Markdown

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request renames the "index-tuning" feature to "automated-tuning" to better reflect its expanded scope, which now includes both index and table tuning recommendations. The change is a comprehensive refactoring that updates command names, function names, variable names, documentation, and help text across the codebase.

  • Renamed CLI command group from index-tuning to automated-tuning
  • Renamed list-recommendations command to list-index-recommendations and added new list-table-recommendations command
  • Updated all function names, variable names, and documentation to use "automated tuning" terminology

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test_rdbms_flexible_commands.py Updated test commands to use the new automated-tuning command group and separated index/table recommendation commands
flexible_server_custom_postgres.py Renamed functions from index_tuning_* to automated_tuning_*, added table_recommendations_list function, and updated error/log messages
flexible_server_commands.py Updated command group registration from index-tuning to automated-tuning and split recommendation commands
_util.py Renamed function from get_index_tuning_settings_map to get_automated_tuning_settings_map
_params.py Updated parameter definitions to use tuning context string instead of index-tuning, renamed parameter from index_tuning_enabled to tuning_enabled
_helptext_pg.py Updated all help text entries from index-tuning to tuning and expanded descriptions to mention both index and table tuning
_flexible_server_location_capabilities_util.py Renamed variable from index_tuning to automated_tuning for consistency
Comments suppressed due to low confidence (1)

src/azure-cli/azure/cli/command_modules/rdbms/_flexible_server_location_capabilities_util.py:114

  • The dictionary key 'index_tuning_supported' should be renamed to 'automated_tuning_supported' to be consistent with the renamed variable and the overall renaming from 'index tuning' to 'automated tuning' throughout the codebase.
        'index_tuning_supported': index_tuning_supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/azure-cli/azure/cli/command_modules/rdbms/_params.py Outdated
@nachoalonsoportillo Nacho Alonso Portillo (nachoalonsoportillo) changed the title Add support for table and index recommendations under a new command group {RDBMS} Add new command group to support all recommendation types for automated tuning Oct 29, 2025
@nachoalonsoportillo Nacho Alonso Portillo (nachoalonsoportillo) changed the title {RDBMS} Add new command group to support all recommendation types for automated tuning {RDBMS} Add auto-tuning command group to support all recommendation types for automated tuning & deprecate index-tuning Oct 29, 2025
@yonzhan

Copy link
Copy Markdown
Collaborator

Please fix CI issues

@evelyn-ys

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@evelyn-ys

Copy link
Copy Markdown
Contributor

Nacho Alonso Portillo (@nachoalonsoportillo) Please resolve conflicts and fix CI failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants