Repository navigation
{Keyvault} az keyvault key sign: Document base64 requirement for digest - #32377
Merged
Merged
Conversation
jack-obrien
requested review from
Zhiyi Huang (calvinhzy),
Yishi Wang (evelyn-ys) and
Jiashuo Li (jiasli)
as code owners
November 4, 2025 12:11
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
Bot
added this to the
November 2025 (2025-11-18)❗ Breaking change release ❗ milestone
|
Hi jack-obrien, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested a review
from Yong Zhang (yonzhan)
November 4, 2025 12:12
Contributor
Author
|
@microsoft-github-policy-service agree |
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution jack-obrien! We will review the pull request and get back to you soon. |
Contributor
Author
|
BTW the base64 in the examples is "foobar" sha256 checksum converted to base64 |
Contributor
|
/azp run |
Yishi Wang (evelyn-ys)
approved these changes
Nov 10, 2025
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az keyvault key signDescription
Document that the digest arg to
signandverifymust be base64 encoded. Spent a little while figuring that out. The error messages are confusing if the input is not encoded correctly too, so it's important to have clear docs.This checklist is used to make sure that common guidelines for a pull request are followed.
[tick ] The PR title and description has followed the guideline in Submitting Pull Requests.
[ tick] I adhere to the Command Guidelines.
[ tick] I adhere to the Error Handling Guidelines.