Generate metric alert commands from 2024-03-01-preview API #32475
+60,127
−719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌AzureCLI-FullTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR generates Azure CLI commands from the 2024-03-01-preview API for monitor metric alerts and related data collection functionality. The changes introduce new command modules for managing data collection endpoints, data collection rules, and application insights workbooks with their associated subresources.
Key Changes:
- Added comprehensive CRUD operations for data collection endpoints and rules
- Implemented workbook management commands including identity and revision operations
- All new commands include confirmation prompts for destructive operations
Reviewed changes
Copilot reviewed 96 out of 236 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| data_collection/rule/*.py | Implements CRUD operations for data collection rules with extensive schema definitions |
| data_collection/endpoint/*.py | Adds data collection endpoint management with association tracking |
| app_insights/workbook/*.py | Provides workbook management including identity assignment and revision history |
| app_insights/workbook/identity/*.py | Handles workbook identity operations (assign, remove, delete, show) |
| app_insights/workbook/revision/*.py | Manages workbook revision listing and retrieval |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "monitor app-insights workbook identity", | ||
| ) | ||
| class __CMDGroup(AAZCommandGroup): | ||
| """Manage workbook idneity |
There was a problem hiding this comment.
Corrected spelling of 'idneity' to 'identity'
Suggested change
| """Manage workbook idneity | |
| """Manage workbook identity |
| """Show workbook revision. | ||
|
|
||
| :example: Show workbook revision | ||
| az monitor app-insights workbook revision list -g rg --resource-name name --revision-id id |
There was a problem hiding this comment.
Example command uses 'list' but this is the 'show' command. The example should use 'show' instead of 'list' to correctly demonstrate this command's usage.
Suggested change
| az monitor app-insights workbook revision list -g rg --resource-name name --revision-id id | |
| az monitor app-insights workbook revision show -g rg --resource-name name --revision-id id |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.