Repository navigation
[ARM] Fix Deployment stacks What-If not rendering the properties body on resource creates and deletes - #34156
Merged
JaysonTaiMicrosoft merged 5 commits intoOct 8, 2026
Conversation
…h deployments what-if.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Top-level configuration such as SKU, identity, and tags remains omitted, leaving the linked issue only partially resolved.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates Deployment Stacks What-If formatting to display nested resource properties for creates and deletes.
Changes:
- Renders
propertiesfrom create/delete configurations. - Extracts reusable inline JSON formatting.
- Updates formatter test expectations.
| File | Description |
|---|---|
_stacks_formatters.py |
Adds create/delete property rendering. |
test_stack_formatters.py |
Updates expected formatted output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Member
Author
|
The PR check failures at this time look unrelated to these changes. |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
JaysonTaiMicrosoft
approved these changes
Oct 7, 2026
Member
Author
|
@Azure/act-identity-squad Ready for review |
Yeming Liu (isra-fel)
approved these changes
Oct 8, 2026
Open
2 of 6 tasks
Kyle Albert (kalbert312)
deleted the
kylea/stacks-whatif-create-delete-rendering-fix
branch
October 8, 2026 15:41
Anthony Martin (anthony-c-martin)
added a commit
to Azure/bicep-deploy
that referenced
this pull request
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az stack-whatifDescription
Fixes Azure/deployment-stacks#259
Testing Guide
See unit test updates.
History Notes
[ARM]
az stack-whatif: Fix resource properties not rendering for resource creates and deletesThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.