Repository navigation
{Compute} az vm update: Fix generic update command --add failed issue - #34157
Merged
Merged
Conversation
microsoft-github-policy-service
Bot
requested review from
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
October 1, 2026 23:57
microsoft-github-policy-service
Bot
added
Compute
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The PR metadata incorrectly identifies az vm update instead of the implemented az vmss update fix.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Fixes az vmss update --add when AAZ omits optional IP configuration collections.
Changes:
- Normalizes missing VMSS networking collections before generic updates.
- Adds unit and recorded scenario regression coverage.
| File | Description |
|---|---|
operations/vmss.py |
Adds update-specific collection normalization. |
custom.py |
Uses the normalized VMSS getter. |
test_custom_vm_commands.py |
Tests normalization behavior and edge cases. |
test_vm_commands.py |
Adds an end-to-end regression test. |
recordings/test_vm_vmss_update_add_lb_backend_pool.yaml |
Records the regression scenario. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @ResourceGroupPreparer(name_prefix='cli_test_vmss_update_lb_pool_', location='swedencentral') | ||
| @ResourceGroupPreparer(name_prefix='cli_test_vmss_update_lb_pool_lb_', location='swedencentral', | ||
| parameter_name='lb_resource_group', key='lb_rg') | ||
| def test_vm_vmss_update_add_lb_backend_pool(self, resource_group, resource_group_location, lb_resource_group): |
Collaborator
|
Compute |
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Teresa Ritorto (teresaritorto)
approved these changes
Oct 5, 2026
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vm updateDescription
Resolve #34133
Testing Guide
test_vm_vmss_update_add_lb_backend_poolandTestVmssGenericUpdateOptionalCollectionsHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.