Repository navigation
[Cloud] az cloud set: Add AzureDelosCloud (Germany sovereign cloud) to the known clouds list - #34200
Open
Yeming Liu (isra-fel) wants to merge 2 commits into
Open
Yeming Liu (isra-fel) wants to merge 2 commits into
Yeming Liu (isra-fel) wants to merge 2 commits into
Conversation
Add the Delos (Germany) sovereign cloud so users can run 'az cloud set --name AzureDelosCloud'. Endpoints and suffixes mirror the Bleu definition with the fr -> de suffix substitution, except where the authoritative sovereign-clouds endpoints doc publishes an explicit Delos value (portal = https://portal.sovcloud.de). active_directory_graph_resource_id intentionally mirrors the Microsoft Graph host rather than exposing the real (deprecated) Azure AD Graph endpoint. synapse_analytics_resource_id is included alongside its suffix counterpart to avoid reintroducing the gap fixed for Bleu in Azure#34059. Part of Azure#34129 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7707d164-8d38-41f6-9884-04c670e74640
microsoft-github-policy-service
Bot
requested review from
Yu Chen (jsntcy),
ZelinWang (wangzelin007) and
Yong Zhang (yonzhan)
October 9, 2026 04:26
microsoft-github-policy-service
Bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The established cloud command scenario tests need canonical and lowercase Delos cases.
1 open finding
What changed in this PR
Adds Germany’s Delos sovereign cloud to Azure CLI’s built-in cloud definitions.
Changes:
- Adds
AzureDelosCloudand its endpoints/suffixes. - Registers Delos in the hard-coded cloud list.
- Adds a release-history entry.
| File | Description |
|---|---|
src/azure-cli-core/HISTORY.rst |
Records Delos cloud support. |
src/azure-cli-core/azure/cli/core/cloud.py |
Defines and registers Delos cloud metadata. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| mariadb_server_endpoint='.mariadb.database.sovcloud-api.de', | ||
| synapse_analytics_endpoint='.dev.azuresynapse.sovcloud-api.de')) | ||
|
|
||
| HARD_CODED_CLOUD_LIST = [AZURE_PUBLIC_CLOUD, AZURE_CHINA_CLOUD, AZURE_US_GOV_CLOUD, AZURE_BLEU_CLOUD, AZURE_DELOS_CLOUD] |
Collaborator
|
Add AzureDelosCloud (Germany sovereign cloud) to the known clouds list |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az cloud set --name AzureDelosCloudDescription
Partially addresses #34129 by adding the Delos (Germany) sovereign cloud to the known clouds list (
CloudNameEnum.AzureDelosCloud+AZURE_DELOS_CLOUD+HARD_CODED_CLOUD_LIST).Values are derived from the authoritative Azure Architecture & Design Team sovereign-clouds endpoints table.
Deliberate decisions:
active_directory_graph_resource_idmirrors the Microsoft Graph host (https://graph.svc.sovcloud.de/) rather than the real (deprecated) Azure AD Graph host. Azure AD Graph is retired and must not be used; this matches the existing Bleu behavior.Testing Guide
Unit tests:
python -m pytest src/azure-cli-core/azure/cli/core/tests/test_cloud.py-> 14 passed, 1 skipped.History Notes
[Cloud]
az cloud set: AddAzureDelosCloud(Germany sovereign cloud) to the known clouds listThis checklist is used to make sure that common guidelines for a pull request are followed.