Repository navigation
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
Yu Chen (jsntcy),
ZelinWang (wangzelin007) and
Yong Zhang (yonzhan)
October 9, 2026 17:56
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Collaborator
|
Please fix CI issues |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az sql db str-policy set,show, andwaitaz sql midb short-term-retention-policy setandshow(live and restorable dropped databases)Description
Add short-term backup immutability support using
2026-08-01-preview, matching the behavior in Azure/azure-powershell#30215.--lock-immutabilityand--yes/-yto both set commands. Onlytrueprompts, with an irreversible-action warning. Cancellation sends no update and emits no result; non-interactive callers must use--yeswhen locking.--lock-immutabilitytogether with--deleted-time, including explicitfalse, and never include that property in a dropped MI database request.immutabilityStatuson set/show for SQL Database and live/dropped MI databases while preserving flattened CLI output.--ids, SQL DB wait, and--no-waitbehavior.azure-mgmt-sql==4.0.0b22unchanged. The referenced https://pypi.org/project/azure-mgmt-sql/5.0.0b2/ introduces hybrid models and unrelated breaking changes; a whole-module SDK migration is deliberately out of scope.Draft / before marking ready
test_sql_db_short_term_retentionandtest_sql_managed_db_short_retentionagainst the new API using dedicated test resources. Both existing playbacks fail: their recordings use2024-11-01-preview; an in-memory diagnostic override additionally confirmed old polling recordings do not cover the newfinal-state-via: locationcontract. No recording files or matchers were changed.Testing Guide
Completed locally against the edited CLI/core source with installed Azure CLI libraries (Python 3.14.6):
python -m unittest azure.cli.command_modules.sql.tests.latest.test_sql_str_policy: 22 tests passed.git diff --check: passed.In a configured developer checkout, run the unit-test command above. For manual service validation, use dedicated disposable resources:
az sql db str-policy show --resource-group MyGroup --server MyServer --name MyDb --query immutabilityStatusaz sql db str-policy set --resource-group MyGroup --server MyServer --name MyDb --lock-immutability trueprompts; decline to verify no update. Accepting is irreversible.az sql midb short-term-retention-policy set --resource-group MyGroup --mi MyInstance --name MyDb --retention-days 7 --lock-immutability true --yesdeliberately skips that confirmation. This locks immutability irreversibly.--lock-immutability trueorfalsewith--deleted-timemust fail before any request.History Notes
[SQL]
az sql db str-policy: Add short-term backup immutability locking with confirmation and expose immutability status[SQL]
az sql midb short-term-retention-policy: Add immutability locking for live databases and expose status for live and dropped databasesThis checklist is used to make sure that common guidelines for a pull request are followed.