[WIP] New /ibdevices CNS API #4002
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces scaffolding for a new CNS /ibdevices API endpoint. It adds the initial handler structure without implementing the actual POST and GET operations, which will be completed in future PRs.
- Adds new IB devices handler function with placeholder TODO comments for POST and GET methods
- Registers the new handler for both v1 and v2 API paths
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cns/restserver/restserver.go | Registers the ibDevicesHandler for both v1 and v2 API paths |
| cns/restserver/api.go | Implements the ibDevicesHandler function with method routing and placeholder TODOs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pjohnst5
changed the title
pjohnst5
changed the title
pjohnst5
changed the title
pjohnst5
force-pushed
the
pjohnst5/cns-post
branch
from
8924aa9 to
b39f8dd
Compare
pjohnst5
force-pushed
the
pjohnst5/cns-post
branch
from
1b21ce5 to
c31ce59
Compare
kmurudi
reviewed
Sep 16, 2025
|
|
||
| func (service *HTTPRestService) createMTPNC(ctx context.Context, pod *v1.Pod, ibMACs []net.HardwareAddr) error { | ||
| // create the MTPNC for the pod | ||
| mtpnc := &v1alpha1.MultitenantPodNetworkConfig{ |
There was a problem hiding this comment.
where is IBMACs being populated? and we should assign Unprogrammed status here if ib mac not in-use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scaffolding for new CNS
/ibdevicesAPIThis is a quick exploration of how CNS would create the MTPNC on a /ibdevices POST
I see we already have some MTPNC reconciling logic in CNS if Swiftv2 is enabled, so will chat with stakeholders about that