Skip to content

Conversation

carlotaarvela
Copy link

@carlotaarvela carlotaarvela commented Sep 5, 2025

Reason for Change:
Populate homeAZ on nodeInfo

Issue Fixed:

Requirements:

Notes:

@carlotaarvela
Copy link
Author

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlotaarvela carlotaarvela marked this pull request as ready for review September 10, 2025 17:18
@Copilot Copilot AI review requested due to automatic review settings September 10, 2025 17:18
@carlotaarvela carlotaarvela requested review from a team as code owners September 10, 2025 17:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the NodeInfo Custom Resource Definition (CRD) by adding HomeAZ (Availability Zone) information alongside the existing VM unique ID. The changes enable CNS to retrieve the HomeAZ from the CNS client and populate it in the NodeInfo CRD for better node management and placement decisions.

  • Adds HomeAZ field population to the NodeInfo CRD creation/update functionality
  • Retrieves HomeAZ information from CNS client and formats it as "AZ%02d"
  • Includes comprehensive test coverage for the new functionality with mocked dependencies
  • Updates Docker base image versions across multiple Dockerfiles

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
cns/service/main.go Adds CNS client integration to retrieve and populate HomeAZ in NodeInfo CRD
cns/service/main_test.go Comprehensive test for NodeInfo CRD creation with HomeAZ validation using mock servers
cns/Dockerfile Updates Azure Linux base image versions
cni/Dockerfile Updates Azure Linux base image versions
.pipelines/build/dockerfiles/cns.Dockerfile Updates Azure Linux base image versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@carlotaarvela
Copy link
Author

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlotaarvela carlotaarvela force-pushed the carlota/homeaz-on-nodeinfocrd branch from ea246be to aab7c06 Compare September 16, 2025 10:53
@carlotaarvela carlotaarvela changed the title Populate homeAZ on nodeInfo CRD feat: Populate homeAZ on nodeInfo CRD Sep 16, 2025
@carlotaarvela carlotaarvela added cns Related to CNS. AZR AZR related PR labels Sep 16, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@carlotaarvela carlotaarvela force-pushed the carlota/homeaz-on-nodeinfocrd branch from aab7c06 to 4b8cd08 Compare September 16, 2025 11:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@carlotaarvela
Copy link
Author

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AZR AZR related PR cns Related to CNS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant