-
Notifications
You must be signed in to change notification settings - Fork 256
feat: Populate homeAZ on nodeInfo CRD #4009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the NodeInfo Custom Resource Definition (CRD) by adding HomeAZ (Availability Zone) information alongside the existing VM unique ID. The changes enable CNS to retrieve the HomeAZ from the CNS client and populate it in the NodeInfo CRD for better node management and placement decisions.
- Adds HomeAZ field population to the NodeInfo CRD creation/update functionality
- Retrieves HomeAZ information from CNS client and formats it as "AZ%02d"
- Includes comprehensive test coverage for the new functionality with mocked dependencies
- Updates Docker base image versions across multiple Dockerfiles
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
cns/service/main.go | Adds CNS client integration to retrieve and populate HomeAZ in NodeInfo CRD |
cns/service/main_test.go | Comprehensive test for NodeInfo CRD creation with HomeAZ validation using mock servers |
cns/Dockerfile | Updates Azure Linux base image versions |
cni/Dockerfile | Updates Azure Linux base image versions |
.pipelines/build/dockerfiles/cns.Dockerfile | Updates Azure Linux base image versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
ea246be
to
aab7c06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aab7c06
to
4b8cd08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
Reason for Change:
Populate homeAZ on nodeInfo
Issue Fixed:
Requirements:
Notes: