Skip writing functions.metadata when using source gen #2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiocav
reviewed
Mar 4, 2025
| <FunctionsAutoRegisterGeneratedMetadataProvider>$(FunctionsEnableWorkerIndexing)</FunctionsAutoRegisterGeneratedMetadataProvider> | ||
| <FunctionsAutoRegisterGeneratedMetadataProvider>$(FunctionsEnableWorkerIndexing)</FunctionsAutoRegisterGeneratedMetadataProvider> | ||
| <_WriteFunctionsMetadata>true</_WriteFunctionsMetadata> | ||
| <_WriteFunctionsMetadata Condition="'$(FunctionsEnableMetadataSourceGen)' == 'true'">false</_WriteFunctionsMetadata> |
There was a problem hiding this comment.
Do we also want to give users the ability to override this behavior? I don't have a concrete scenario in mind, but if users have a dependency on that file for anything, having a property they can set would help preserve this behavior until the next major version, where we can permanently remove it.
There was a problem hiding this comment.
What should our default be? Write or don't write? I have it as default don't write for now, which could be considered a breaking change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #1058
Pull request checklist
release_notes.mdAdditional information
Skips writing functions.metadata when using source gen version of function metadata provider.