Allow inherited lists as reference types #642
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me fix those tests first 😄 |
|
Can we accelerate this? |
|
Any progress on this bug? We just got hit by this and seems to be pretty serious this is not working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue that inherited lists (or custom implementations of
IEnumerable<T>) cannot be used and will lead to runtime exceptions (e.g. #380).Implementation Detail:
Namespace?.StartsWith("System")) and custom / inherited enumerable implementationsListObjectTypeVisitorto produce a reference if a custom list is used (as an alternative we could implement anotherVisitor)IsReferencedOpenApiArraychecks where necessaryI added additional unit / integration tests to cover this use case.
Let me know what you think and if you favor changes / a different implementation. If accepted this approach could be applied for dictionaries also (#313), see proof of concept branch Dresel:v2-dictionary-as-reference-types.