Fix bug that causes the configuration version to go out of enum bounds when reading from environment #669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description: This PR fixes a bug that causes the property "version" in the default configuration to go out of enum bounds, caused by a missing enum validation.
Bug: If you input a single integer as a value for the environment variable: "OpenApi__Version", the integer slips into the property, despite being out of enum bounds.
Reproduction: Use this as an environment variable before running: "OpenApi__Version=3"
Consequence: Error in the SwaggerUI when rendering, because /api/swagger.json throws exception.
Stack-Trace when calling /api/swagger.json:
Reason:
Excerpt from the method documentation of Enum.TryParse<>():
Fix: Validate the enum value and fallback to version 2, if out of bounds.