Skip to content

fix: test fixes for EventHub #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2025
Merged

fix: test fixes for EventHub #108

merged 3 commits into from
Apr 3, 2025

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Apr 3, 2025 •
edited
Loading

Functionality related

  • eventData.py: renamed SDK import as EventDataSDK
    • prevents conflict between two identically named classes (eg: throwing this error during execution: EventData does not have property "_from_message")
  • eventDataConverter.py: removed pytype != EventData check
    • Since batches are supported, the pytype can also be List[EventData]
  • pyproject.toml: added uamqp as dependency
    • Necessary for decoding the message

Testing related

  • Added test_code_quality.py file for linting
  • Fixed tests
  • Lint

Pipeline related

  • Added EH build to public & official build pipelines

@EvanR-Dev EvanR-Dev self-requested a review April 3, 2025 16:15
@hallvictoria hallvictoria marked this pull request as ready for review April 3, 2025 16:20
@hallvictoria hallvictoria merged commit cb8a6e3 into dev Apr 3, 2025
38 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/eh-fixes branch April 3, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavin-aguiar gavin-aguiar gavin-aguiar approved these changes

@EvanR-Dev EvanR-Dev Awaiting requested review from EvanR-Dev EvanR-Dev is a code owner

@vrdmr vrdmr Awaiting requested review from vrdmr vrdmr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hallvictoria @gavin-aguiar