feat: allow properties_to_modify arg for settlement methods
#143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallvictoria
requested review from
vrdmr,
gavin-aguiar and
EvanR-Dev
as code owners
gavin-aguiar
approved these changes
Oct 7, 2025
| # Encode map | ||
| def encode_amqp_map(dct): | ||
| if not dct: | ||
| return b"" |
There was a problem hiding this comment.
If the dct is empty, shouldn't we still encode it with size= 1?
There was a problem hiding this comment.
Before this change, I had request.propertiesToModify = b"". I return just b"" here to keep the behavior consistent with what we had before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142
Allows for customers to send the following types in their dictionary:
Depending on the dict value type, the value is appropriately encoded into an amqp format.