Skip to content

Fix 'Counters mismatch' error on dangling symlink#1266

Merged
robertwoj-microsoft merged 2 commits into
devfrom
robertwoj/bugfixes/37544355
Apr 21, 2026
Merged

Fix 'Counters mismatch' error on dangling symlink#1266
robertwoj-microsoft merged 2 commits into
devfrom
robertwoj/bugfixes/37544355

Conversation

@robertwoj-microsoft
Copy link
Copy Markdown
Contributor

Description

Fix an issue that the compliance engine FileRegexMatch procedure fails with error if a dangling symlink exists.
The dangling symlink error works properly, but the counter should not be bumped there.

Checklist

  • I have read the contribution guidelines.
  • I added unit-tests to validate my changes. All unit tests are passing.
  • I have merged the latest dev branch prior to this PR submission.
  • I ran pre-commit on my changes prior to this PR submission.
  • I submitted this PR against the dev branch.

@robertwoj-microsoft robertwoj-microsoft requested review from a team as code owners April 16, 2026 09:31
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

Test Results

 33 files  +   32   33 suites   - 30   20m 59s ⏱️ + 19m 39s
  4 tests  - 1 125    4 ✅  - 1 125   0 💤 ± 0  0 ❌ ±0 
132 runs   -   997  110 ✅  - 1 019  22 💤 +22  0 ❌ ±0 

Results for commit 4218140. ± Comparison against base commit 4d6969f.

This pull request removes 1129 and adds 4 tests. Note that renamed tests count towards both.
AuditdRulesCheckTest ‑ AuditctlCommandFails
AuditdRulesCheckTest ‑ ExcludeOptionsSkipsMatchingRules
AuditdRulesCheckTest ‑ ImmutableRuleCompliant
AuditdRulesCheckTest ‑ ImmutableRuleMissingIsNonCompliant
AuditdRulesCheckTest ‑ InvalidExcludeOptionsRegexReturnsError
AuditdRulesCheckTest ‑ InvalidOverridePathReturnsNonCompliant
AuditdRulesCheckTest ‑ InvalidRequiredOptionsRegexReturnsError
AuditdRulesCheckTest ‑ MultiSyscallOneMissingInFilesIsNonCompliant
AuditdRulesCheckTest ‑ OverridePathMissingFileRuleIsNonCompliant
AuditdRulesCheckTest ‑ OverridePathWithMatchingFileRuleIsCompliant
…
/mnt/vss/_work/azure-osconfig/azure-osconfig/src/tests/universal-nrp-e2e/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Get.Ensure all resource instances have status
/mnt/vss/_work/azure-osconfig/azure-osconfig/src/tests/universal-nrp-e2e/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Get.Ensure reasons are properly populated
/mnt/vss/_work/azure-osconfig/azure-osconfig/src/tests/universal-nrp-e2e/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Get.Ensure the total resource instances count
/mnt/vss/_work/azure-osconfig/azure-osconfig/src/tests/universal-nrp-e2e/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Set.Perform remediation

♻️ This comment has been updated with latest results.

Comment thread src/modules/complianceengine/src/lib/procedures/FileRegexMatch.cpp
@robertwoj-microsoft robertwoj-microsoft force-pushed the robertwoj/bugfixes/37544355 branch from e4ea60a to 4218140 Compare April 20, 2026 06:58
@robertwoj-microsoft robertwoj-microsoft merged commit 817fbcd into dev Apr 21, 2026
124 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants