Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liftr Dynatrace pwsh cmdlets for stable version 2023-04-27 #27241

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

shivansh257
Copy link

@shivansh257 shivansh257 commented Feb 27, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Shivansh Agarwal and others added 4 commits February 27, 2025 14:33
* Update AddAzureVirtualNetworkPeeringCommand.cs

* Update Network.format.ps1xml

* Update PSVirtualNetworkPeering.cs

* Update Add-AzVirtualNetworkPeering.md

* Update Add-AzVirtualNetworkPeering.md

* Update ChangeLog.md

* Update AddAzureVirtualNetworkPeeringCommand.cs

* Update PSVirtualNetworkPeering.cs

* Update Network.format.ps1xml

* Update VirtualNetworkTests.ps1

* Update VirtualNetworkTests.cs

* Create TestSubnetPeeringCRUD.json

* Create TestSubnetPeeringSyncCRUD.json

* Update ChangeLog for subnet peering support

* Fix build errors

* Fix singular names build error

* Fix build errors by renaming plural to singular names

* Revert "Fix access token cache issue (Azure#27050)"

This reverts commit 58d9dc1.

* Try to fix subnet outbound error

* Fix UT and generate json in record mode

* Fix access token cache issue (Azure#27050)

* Fix access token cache issue

* Update doc and script

* Appened the error message to be suppressed

* Revert "Appened the error message to be suppressed"

This reverts commit 31408a2.

* Revert "Fix access token cache issue (Azure#27050)"

This reverts commit 58d9dc1.

* Record remaining tests

* Fix access token cache issue (Azure#27050)

* Fix access token cache issue

* Update doc and script

---------

Co-authored-by: Yabo Hu <[email protected]>
Co-authored-by: SatyamurtiDoddini <[email protected]>
Co-authored-by: Satyamurti Doddini <[email protected]>
Co-authored-by: Vincent Dai <[email protected]>
@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@notyashhh
Copy link
Member

notyashhh commented Mar 3, 2025

Hi @shivansh257,

  1. Can you please resolve the failing test cases?

  2. Also the Static Analysis issues that need to resolved can be found here

Please feel free to ping me anytime :)
(even if you need to trigger the pipeline to test)

@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.