Fixing SQL Import Export issue with Managed Identity #28285
+3,922
−19,625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with SQL Import/Export cmdlets when using Managed Identity authentication where the password parameter was required even though it's not needed for this authentication type.
- Made the
AdministratorLoginPasswordparameter optional in the base cmdlet class - Updated the service adapter to only decrypt and set the password when not using Managed Identity authentication
- Updated unit tests to reflect the parameter changes
Reviewed Changes
Copilot reviewed 8 out of 34 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
ImportExportCmdletArmBase.cs |
Made AdministratorLoginPassword parameter optional by removing Mandatory=true and ValidateNotNullOrEmpty attributes |
ImportExportDatabaseAdapter.cs |
Added conditional logic to only set password when authentication type is not ManagedIdentity |
AzureSqlDatabaseImportExportTests.cs |
Updated unit tests to expect AdministratorLoginPassword as non-mandatory parameter |
ChangeLog.md |
Added changelog entries documenting the fix for both export and import cmdlets |
| Other test files | Updated test session records and test scripts (not core to the PR's functionality) |
src/Sql/Sql/ChangeLog.md
Outdated
Comment on lines
21
to
22
| * Fixed `New-AzSqlDatabaseExport` to use SQL Authentication with ManagedIdentity without any manadatory password | ||
| * Fixed `New-AzSqlDatabaseImport` to use SQL Authentication with ManagedIdentity without any manadatory password |
There was a problem hiding this comment.
There is a spelling error: 'manadatory' should be 'mandatory'.
Suggested change
| * Fixed `New-AzSqlDatabaseExport` to use SQL Authentication with ManagedIdentity without any manadatory password | |
| * Fixed `New-AzSqlDatabaseImport` to use SQL Authentication with ManagedIdentity without any manadatory password | |
| * Fixed `New-AzSqlDatabaseExport` to use SQL Authentication with ManagedIdentity without any mandatory password | |
| * Fixed `New-AzSqlDatabaseImport` to use SQL Authentication with ManagedIdentity without any mandatory password |
Copilot uses AI. Check for mistakes.
src/Sql/Sql/ChangeLog.md
Outdated
Comment on lines
21
to
22
| * Fixed `New-AzSqlDatabaseExport` to use SQL Authentication with ManagedIdentity without any manadatory password | ||
| * Fixed `New-AzSqlDatabaseImport` to use SQL Authentication with ManagedIdentity without any manadatory password |
There was a problem hiding this comment.
There is a spelling error: 'manadatory' should be 'mandatory'.
Suggested change
| * Fixed `New-AzSqlDatabaseExport` to use SQL Authentication with ManagedIdentity without any manadatory password | |
| * Fixed `New-AzSqlDatabaseImport` to use SQL Authentication with ManagedIdentity without any manadatory password | |
| * Fixed `New-AzSqlDatabaseExport` to use SQL Authentication with ManagedIdentity without any mandatory password | |
| * Fixed `New-AzSqlDatabaseImport` to use SQL Authentication with ManagedIdentity without any mandatory password |
Copilot uses AI. Check for mistakes.
| @@ -81,6 +81,11 @@ public AzureSqlDatabaseImportExportBaseModel Export(AzureSqlDatabaseImportExport | |||
| parameters.AuthenticationType = exportRequest.AuthenticationType.ToString().ToLowerInvariant(); | |||
| } | |||
|
|
|||
| if (exportRequest.AuthenticationType != AuthenticationType.ManagedIdentity) | |||
| { | |||
| parameters.AdministratorLoginPassword = AzureSqlServerAdapter.Decrypt(exportRequest.AdministratorLoginPassword); | |||
There was a problem hiding this comment.
Consider checking if AdministratorLoginPassword is null before attempting to decrypt it, as making the parameter optional means it could be null even for non-ManagedIdentity authentication types.
Suggested change
| parameters.AdministratorLoginPassword = AzureSqlServerAdapter.Decrypt(exportRequest.AdministratorLoginPassword); | |
| if (!string.IsNullOrEmpty(exportRequest.AdministratorLoginPassword)) | |
| { | |
| parameters.AdministratorLoginPassword = AzureSqlServerAdapter.Decrypt(exportRequest.AdministratorLoginPassword); | |
| } |
Copilot uses AI. Check for mistakes.
| @@ -124,6 +129,11 @@ public AzureSqlDatabaseImportExportBaseModel ImportNewDatabase(AzureSqlDatabaseI | |||
| parameters.AuthenticationType = importRequest.AuthenticationType.ToString().ToLowerInvariant(); | |||
| } | |||
|
|
|||
| if (importRequest.AuthenticationType != AuthenticationType.ManagedIdentity) | |||
| { | |||
| parameters.AdministratorLoginPassword = AzureSqlServerAdapter.Decrypt(importRequest.AdministratorLoginPassword); | |||
There was a problem hiding this comment.
Consider checking if AdministratorLoginPassword is null before attempting to decrypt it, as making the parameter optional means it could be null even for non-ManagedIdentity authentication types.
Suggested change
| parameters.AdministratorLoginPassword = AzureSqlServerAdapter.Decrypt(importRequest.AdministratorLoginPassword); | |
| if (importRequest.AdministratorLoginPassword != null) | |
| { | |
| parameters.AdministratorLoginPassword = AzureSqlServerAdapter.Decrypt(importRequest.AdministratorLoginPassword); | |
| } |
Copilot uses AI. Check for mistakes.
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There exists an issue with Import Export using Managed Identity where it asks for SQL Authentication Password even though it is not required. This PR fixes the issue by making the password parameter from the Import Export cmdlet optional
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.