Make propagateStaticRoutes read/write#42616
Open
rchepala wants to merge 1 commit intoAzure:release-microsoft-network-2025-07-01from
Open
Make propagateStaticRoutes read/write#42616rchepala wants to merge 1 commit intoAzure:release-microsoft-network-2025-07-01from
rchepala wants to merge 1 commit intoAzure:release-microsoft-network-2025-07-01from
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Important checks have failed. As of today they are not blocking this PR, but in near future they may. Addressing the following failures is highly recommended:
Comment generated by summarize-checks workflow run. |
github-actions
Bot
added
ARMReview
resource-manager
TypeSpec
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
Comment generated by After APIView workflow run. |
rchepala
force-pushed
the
rchepala/propagateStaticRoutes-readwrite
branch
from
29a5265 to
bf17a54
Compare
rchepala
force-pushed
the
rchepala/propagateStaticRoutes-readwrite
branch
from
bf17a54 to
2cf15b7
Compare
razvanbadea-msft
added
ARMSignedOff
github-actions
Bot
added
ARMAutoSignedOff-IncrementalTSP
and removed
WaitForARMFeedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Making propagateStaticRoutes read/write to address this IcM and to be in sync with the backend functionality.
Validation
Prettier and TypeSpec
Validation
This removes an incorrect readOnly: true annotation from propagateStaticRoutes in StaticRoutesConfig. Per OAD rule 1029 documentation: "not a breaking change if from 'true' to 'false'" , making a property writable is non-breaking for existing clients. Additionally, the backend has always accepted writes, the spec annotation was wrong.