Skip to content

Make propagateStaticRoutes read/write#42616

Merged
rchepala merged 1 commit intoAzure:release-microsoft-network-2025-07-01from
rchepala:rchepala/propagateStaticRoutes-readwrite
Apr 27, 2026
Merged

Make propagateStaticRoutes read/write#42616
rchepala merged 1 commit intoAzure:release-microsoft-network-2025-07-01from
rchepala:rchepala/propagateStaticRoutes-readwrite

Conversation

@rchepala
Copy link
Copy Markdown

@rchepala rchepala commented Apr 23, 2026

Description

Making propagateStaticRoutes read/write to address this IcM and to be in sync with the backend functionality.

Validation

Prettier and TypeSpec

Validation

This removes an incorrect readOnly: true annotation from propagateStaticRoutes in StaticRoutesConfig. Per OAD rule 1029 documentation: "not a breaking change if from 'true' to 'false'" , making a property writable is non-breaking for existing clients. Additionally, the backend has always accepted writes, the spec annotation was wrong.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Next Steps to Merge

Important checks have failed. As of today they are not blocking this PR, but in near future they may.
Addressing the following failures is highly recommended:
  • ⚠️ The check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.
If you still want to proceed merging this PR without addressing the above failures, refer to step 4 in the PR workflow diagram.

Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added ARMReview resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.Network
Go sdk/resourcemanager/network/armnetwork
Java com.azure.resourcemanager:azure-resourcemanager-network
JavaScript @azure/arm-network

Comment generated by After APIView workflow run.

@rchepala rchepala force-pushed the rchepala/propagateStaticRoutes-readwrite branch from bf17a54 to 2cf15b7 Compare April 24, 2026 00:18
@razvanbadea-msft razvanbadea-msft added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Approved-Avocado labels Apr 24, 2026
@github-actions github-actions Bot added ARMAutoSignedOff-IncrementalTSP and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 24, 2026
@santoshgh317 santoshgh317 self-requested a review April 27, 2026 10:18
@rchepala rchepala merged commit a0c3fd2 into Azure:release-microsoft-network-2025-07-01 Apr 27, 2026
125 of 138 checks passed
@rchepala rchepala deleted the rchepala/propagateStaticRoutes-readwrite branch April 27, 2026 10:23
santoshgh317 pushed a commit that referenced this pull request Apr 28, 2026
)

* Make propagateStaticRoutes read/write (#42616)

Co-authored-by: Rajkumar Chepala <[email protected]>

* Swagger changes for Vwan Express Route Gateway Failover and Insights (#42560)

* swagger changes for vwan express route gateway apis

* fixed errros

* fixed errros

* fixed errros

* fixed errros

* add suppression

* Delete specification/network/resource-manager/Microsoft.Network/Network/sdk-suppressions.yaml

* reverted back compatible.tsp

---------

Co-authored-by: Shubhika Jain <[email protected]>
Co-authored-by: judy <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
Co-authored-by: Venu Sivanadham <[email protected]>

---------

Co-authored-by: Rajkumar Chepala <[email protected]>
Co-authored-by: Rajkumar Chepala <[email protected]>
Co-authored-by: Shubhika Jain <[email protected]>
Co-authored-by: judy <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
Co-authored-by: Venu Sivanadham <[email protected]>
santoshgh317 pushed a commit that referenced this pull request Apr 28, 2026
* link fialover swagger

* fixed errors

* added in readme

* add suppression

* update suppression

* updated doc

* reverted back-compatible changes

* Merging Circuit link failover final cp 2 branch with latest pull (#42690)

* Make propagateStaticRoutes read/write (#42616)

Co-authored-by: Rajkumar Chepala <[email protected]>

* Swagger changes for Vwan Express Route Gateway Failover and Insights (#42560)

* swagger changes for vwan express route gateway apis

* fixed errros

* fixed errros

* fixed errros

* fixed errros

* add suppression

* Delete specification/network/resource-manager/Microsoft.Network/Network/sdk-suppressions.yaml

* reverted back compatible.tsp

---------

Co-authored-by: Shubhika Jain <[email protected]>
Co-authored-by: judy <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
Co-authored-by: Venu Sivanadham <[email protected]>

---------

Co-authored-by: Rajkumar Chepala <[email protected]>
Co-authored-by: Rajkumar Chepala <[email protected]>
Co-authored-by: Shubhika Jain <[email protected]>
Co-authored-by: judy <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
Co-authored-by: Venu Sivanadham <[email protected]>

* resolved merged conflicts:1 (#42715)

Co-authored-by: Shubhika Jain <[email protected]>

---------

Co-authored-by: Shubhika Jain <[email protected]>
Co-authored-by: judy <[email protected]>
Co-authored-by: Venu Sivanadham <[email protected]>
Co-authored-by: Rajkumar Chepala <[email protected]>
Co-authored-by: Rajkumar Chepala <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
rchepala added a commit to rchepala/azure-rest-api-specs that referenced this pull request Apr 28, 2026
santoshgh317 pushed a commit that referenced this pull request Apr 29, 2026
* link fialover swagger

* fixed errors

* added in readme

* add suppression

* update suppression

* updated doc

* reverted back-compatible changes

* Merging Circuit link failover final cp 2 branch with latest pull (#42690)

* Make propagateStaticRoutes read/write (#42616)



* Swagger changes for Vwan Express Route Gateway Failover and Insights (#42560)

* swagger changes for vwan express route gateway apis

* fixed errros

* fixed errros

* fixed errros

* fixed errros

* add suppression

* Delete specification/network/resource-manager/Microsoft.Network/Network/sdk-suppressions.yaml

* reverted back compatible.tsp

---------






---------








* resolved merged conflicts:1 (#42715)



---------

Co-authored-by: Shubhika Jain <[email protected]>
Co-authored-by: judy <[email protected]>
Co-authored-by: Venu Sivanadham <[email protected]>
Co-authored-by: Rajkumar Chepala <[email protected]>
Co-authored-by: Rajkumar Chepala <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants