Skip to content

DiskRP Swagger — Add snapshotAccessState to DiskRestorePointProperties for InstantAccess - #42620

Merged
Haider Agha (haagha) merged 1 commit into
Azure:compute-2026-03-02from
akashpargat:diskRP/akashpargat/swagger/InstantAccessRestorePoint
May 6, 2026
Merged

Haider Agha (haagha) merged 1 commit into
Azure:compute-2026-03-02from
akashpargat:diskRP/akashpargat/swagger/InstantAccessRestorePoint

Conversation

@akashpargat

Copy link
Copy Markdown
Contributor

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

  • Other, please clarify:
    • Add snapshotAccessState property to DiskRestorePointProperties starting from API version 2026-03-02

Due diligence checklist

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines.
  • A release plan has been created.

Summary

Adds \snapshotAccessState\ (read-only) to \DiskRestorePointProperties\ for the InstantAccess Restore Point feature. This property already exists on \SnapshotProperties\ and uses the existing \SnapshotAccessState\ enum from \common/models.tsp. The DiskRP backend already computes and returns this field.

Changes

  • \ComputeDisk/models.tsp\ — Added \snapshotAccessState\ to \DiskRestorePointProperties\
  • \stable/2026-03-02/DiskRP.json\ — Generated swagger output
  • Example JSON files for DiskRestorePoint GET with InstantAccess

Added snapshotAccessState property to DiskRestorePointProperties in TypeSpec
and generated OpenAPI spec for API version 2026-03-02. This property already
exists on SnapshotProperties. The SnapshotAccessState enum already exists in
common/models.tsp — no new types needed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Apr 23, 2026 •

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes in the generated SDK for Go (label: BreakingChange-Go-Sdk). Refer to step 3 in the PR workflow diagram.


Comment generated by summarize-checks workflow run.

@github-actions

github-actions Bot commented Apr 23, 2026 •

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec ComputeDisk
Go sdk/resourcemanager/compute/armcompute
Java com.azure.resourcemanager:azure-resourcemanager-compute
JavaScript @azure/arm-compute
Python azure-mgmt-compute

Comment generated by After APIView workflow run.

@haagha Haider Agha (haagha) added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 4, 2026
@gary-x-li Gary Li (gary-x-li) added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 6, 2026
@haagha
Haider Agha (haagha) merged commit a3930bc into Azure:compute-2026-03-02 May 6, 2026
127 of 130 checks passed
Haider Agha (haagha) added a commit that referenced this pull request Jun 22, 2026
* Add Disk RP api-version 2026-03-02

* Fix broken common-types  paths in DiskRP.json (2026-03-02)

The DiskRP.json swagger had incorrect relative  paths using
'../../../common-types/v1/common.json' (3 levels up) which resolves to
a non-existent 'Microsoft.Compute/common-types/' path. Fixed to use
'../../common-types/v1/common.json' (2 levels up) matching the correct
'Compute/common-types/' location, consistent with other DiskRP versions.

* Update DiskRP.json

* fix: update package tags and input files for Compute API specifications

* Add snapshotAccessState to DiskRestorePointProperties for InstantAccess (#42620) (ARM Approved)

Added snapshotAccessState property to DiskRestorePointProperties in TypeSpec
and generated OpenAPI spec for API version 2026-03-02. This property already
exists on SnapshotProperties. The SnapshotAccessState enum already exists in
common/models.tsp — no new types needed.

Co-authored-by: NORTHAMERICA\akashpargat <akashpargat@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Swagger changes for ConfidentialVMVersion (#42541) ( ARMSignedOff)

* swagger changes for confidentialVMVersion

* addressing comments

* DiskRP Swagger changes -- adding two APIs support for immutable snapshot -- for 2026-03-02 (#42025)

* v2

* v2

* v3

* v3 snapshot and compile

* V3 fix1

* v4 fix 2

* Suppress ResourceNameRestriction for snapshot updateImmutabilityPolicy paths in DiskRP.json

* Remove ineffective where: selector from snapshot ResourceNameRestriction suppression

---------

Co-authored-by: Rui Zhan <rzhan@microsoft.com>
Co-authored-by: Haider Agha <64601174+haagha@users.noreply.github.com>
Co-authored-by: Haider Agha <Haider.Agha@microsoft.com>

* Address ARM API review feedback for snapshot immutability policy

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Update immutability policy examples with response fields and async headers

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Refactor immutability policy documentation and examples for snapshots

---------

Co-authored-by: Haider Agha <Haider.Agha@microsoft.com>
Co-authored-by: Tong Xu (Wicresoft North America Ltd) <v-xuto@microsoft.com>
Co-authored-by: Akash Pargat <akashpargat@yahoo.com>
Co-authored-by: NORTHAMERICA\akashpargat <akashpargat@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: aayushkher <153165259+aayushkher@users.noreply.github.com>
Co-authored-by: zhanrz88-sudo <zhanrz88@gmail.com>
Co-authored-by: Rui Zhan <rzhan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants