Remove service TypeSpec requirement suppressions - #46883
Draft
Timothee Guerin (timotheeguerin) wants to merge 1 commit into
Draft
Timothee Guerin (timotheeguerin) wants to merge 1 commit into
Timothee Guerin (timotheeguerin) wants to merge 1 commit into
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service-level
TypeSpecRequirementexemptions still bypass the check after migration. This draft removes all 2,846 entries across 223 specification folders to try running without those exemptions. Other suppression types are unchanged; files containing only the removed entries are deleted.Related: #28697 and #41726. This does not change the check's existing-version warning behavior or implement a "once migrated, always TypeSpec" rule.
Known blocker: directly checking AKS
preparedimagespecification/preview/2026-05-02-previewwithout its suppression reproduces the documented path-parsing false positive: the checker looks fortspconfig.yamlunderpreview/rather than the service root. Those suppressions are deliberately removed too in this experiment; the parser needs a follow-up fix before removal is safe for every affected path.CI limitation: TypeSpec Requirement only examines changed Swagger JSON files. This suppression-only PR will not automatically revalidate the existing Swagger files, so a green check alone is not evidence that every removed exemption is safe.