Skip to content

Remove service TypeSpec requirement suppressions - #46883

Draft
Timothee Guerin (timotheeguerin) wants to merge 1 commit into
mainfrom
timotheeguerin/remove-typespec-requirement-suppressions
Draft

Timothee Guerin (timotheeguerin) wants to merge 1 commit into
mainfrom
timotheeguerin/remove-typespec-requirement-suppressions

Conversation

@timotheeguerin

Copy link
Copy Markdown
Member

Service-level TypeSpecRequirement exemptions still bypass the check after migration. This draft removes all 2,846 entries across 223 specification folders to try running without those exemptions. Other suppression types are unchanged; files containing only the removed entries are deleted.

Related: #28697 and #41726. This does not change the check's existing-version warning behavior or implement a "once migrated, always TypeSpec" rule.

Known blocker: directly checking AKS preparedimagespecification/preview/2026-05-02-preview without its suppression reproduces the documented path-parsing false positive: the checker looks for tspconfig.yaml under preview/ rather than the service root. Those suppressions are deliberately removed too in this experiment; the parser needs a follow-up fix before removal is safe for every affected path.

CI limitation: TypeSpec Requirement only examines changed Swagger JSON files. This suppression-only PR will not automatically revalidate the existing Swagger files, so a green check alone is not evidence that every removed exemption is safe.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named Swagger Avocado has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant