Skip to content

GeoDR preparation - EventHubs Offset is a string, not an integer encoded as a string#6461

Merged
LarryOsterman merged 2 commits intoAzure:mainfrom
LarryOsterman:larryo/eh_offset_is_string
Mar 27, 2025
Merged

GeoDR preparation - EventHubs Offset is a string, not an integer encoded as a string#6461
LarryOsterman merged 2 commits intoAzure:mainfrom
LarryOsterman:larryo/eh_offset_is_string

Conversation

@LarryOsterman
Copy link
Member

Treat Offset fields in Event Hubs as strings, not integers.

With the upcoming GeoDR functionality in Event Hubs, the Offset field needs to contain string data to handle BCDR recovery scenarios.

This change updates the Event Hubs client to respect the on-the-wire encoding of the Offset field rather than attempting to treat the Offset field as an integer type. It also only allows encoding the Offset field as a string, any other encoding is ignored.

GitHub Copilot Summary

This pull request includes multiple changes to the Azure Event Hubs SDK, focusing on modifying the Offset type from numeric to string across various components. The changes span multiple files and include updates to the implementation, tests, and constants.

Changes to Offset Type:

Test Updates:

These changes ensure that the Offset type is consistently treated as a string across the Azure Event Hubs SDK, simplifying the handling of offsets and aligning with the expected data format.

Copilot AI review requested due to automatic review settings March 12, 2025 18:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 12, 2025

API change check

API changes are not detected in this pull request.

@LarryOsterman LarryOsterman merged commit 5652d3a into Azure:main Mar 27, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants