Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14196#6975

Open
azure-sdk wants to merge 1 commit intomainfrom
sync-eng/common-benbp/delete-storage-sync-14196
Open

Sync eng/common directory with azure-sdk-tools for PR 14196#6975
azure-sdk wants to merge 1 commit intomainfrom
sync-eng/common-benbp/delete-storage-sync-14196

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14196 See eng/common workflow

Copilot AI review requested due to automatic review settings February 26, 2026 22:35
@azure-sdk azure-sdk requested a review from a team as a code owner February 26, 2026 22:35
@azure-sdk azure-sdk requested a review from benbp February 26, 2026 22:35
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Feb 26, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs the eng/common directory with azure-sdk-tools for PR #14196, updating test resource management scripts to support a new Azure subscription and adding functionality to clean up Storage Sync Services that block resource group deletion.

Changes:

  • Added a new Remove-StorageSyncServices function to handle cleanup of Storage Sync Services and their associated endpoints
  • Updated default subscription from "Azure SDK Developer Playground" to "Azure SDK Test Resources - TME" across multiple scripts
  • Added -WarningAction Ignore flags to Select-AzSubscription calls to suppress warnings
  • Added module requirements for Az.Storage and Az.StorageSync in Remove-TestResources.ps1

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
eng/common/scripts/Helpers/Resource-Helpers.ps1 Adds Remove-StorageSyncServices function to recursively clean up sync services, groups, and endpoints before resource group deletion
eng/common/TestResources/Update-TestResources.ps1 Updates default subscription to TME, adds warning suppression, and contains a bug in exit action subscription restoration
eng/common/TestResources/Remove-TestResources.ps1 Adds module requirements, updates default subscription to TME, adds warning suppression, and calls new Remove-StorageSyncServices function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants