Sync eng/common directory with azure-sdk-tools for PR 14196#6975
Open
Sync eng/common directory with azure-sdk-tools for PR 14196#6975
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with azure-sdk-tools for PR #14196, updating test resource management scripts to support a new Azure subscription and adding functionality to clean up Storage Sync Services that block resource group deletion.
Changes:
- Added a new
Remove-StorageSyncServicesfunction to handle cleanup of Storage Sync Services and their associated endpoints - Updated default subscription from "Azure SDK Developer Playground" to "Azure SDK Test Resources - TME" across multiple scripts
- Added
-WarningAction Ignoreflags toSelect-AzSubscriptioncalls to suppress warnings - Added module requirements for Az.Storage and Az.StorageSync in Remove-TestResources.ps1
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/Helpers/Resource-Helpers.ps1 | Adds Remove-StorageSyncServices function to recursively clean up sync services, groups, and endpoints before resource group deletion |
| eng/common/TestResources/Update-TestResources.ps1 | Updates default subscription to TME, adds warning suppression, and contains a bug in exit action subscription restoration |
| eng/common/TestResources/Remove-TestResources.ps1 | Adds module requirements, updates default subscription to TME, adds warning suppression, and calls new Remove-StorageSyncServices function |
benbp
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14196 See eng/common workflow