Conversation
…oft.Network/TrafficManager/tspconfig.yaml', API Version: 2024-04-01-preview, SDK Release Type: beta, and CommitSHA: 'edf549eca6a93cb812a4a799f133ebb6726c76c8' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6155072 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
Bot
added
the
Mgmt
JiaqiZhang-Dev
requested review from
JiaqiZhang-Dev and
tadelesh
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the armtrafficmanager Go management SDK to the 2024-04-01-preview Traffic Manager API version, including new models/enums and a breaking rename of update operations.
Changes:
- Bumped REST API version usage across clients and example tests to
2024-04-01-preview. - Introduced
RecordTypesupport and update-specific request models (ProfileUpdate,EndpointUpdate) plusUpdateV2operations. - Updated fake servers, options/response types, and changelog to reflect the new API surface.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/resourcemanager/trafficmanager/armtrafficmanager/usermetricskeys_client_example_test.go | Updates example metadata and subscription ID placeholder for the new API version. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/usermetricskeys_client.go | Bumps api-version query param and generated API version comments. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/tsp-location.yaml | Updates source spec commit reference. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/testdata/_metadata.json | Bumps tracked API version and emitter version. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/responses.go | Renames update response types to *UpdateV2Response. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/profiles_client_example_test.go | Updates examples to new API version; adds new RecordType examples; switches to UpdateV2. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/profiles_client.go | Updates api-version and replaces Update with UpdateV2 using new request/response types. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/options.go | Renames update options types to *UpdateV2Options. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/models_serde.go | Adds JSON (un)marshalers for new update models and serializes recordType. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/models.go | Adds new enum field RecordType and new update-specific model types. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/heatmap_client_example_test.go | Updates examples to new API version and subscription ID placeholder. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/heatmap_client.go | Bumps api-version query param and generated API version comments. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/geographichierarchies_client_example_test.go | Updates example metadata to new API version. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/geographichierarchies_client.go | Bumps api-version query param and generated API version comments. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/fake/profiles_server.go | Updates fake transport to dispatch UpdateV2 and unmarshal ProfileUpdate. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/fake/endpoints_server.go | Updates fake transport to dispatch UpdateV2 and unmarshal EndpointUpdate. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/endpoints_client_example_test.go | Updates examples to new API version and switches endpoint update example to UpdateV2. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/endpoints_client.go | Updates api-version and replaces Update with UpdateV2 using EndpointUpdate. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/constants.go | Adds RecordType enum and possible values helper. |
| sdk/resourcemanager/trafficmanager/armtrafficmanager/CHANGELOG.md | Updates release date and records breaking changes / newly added API surface. |
| Endpoints: []*armtrafficmanager.Endpoint{ | ||
| { | ||
| Name: to.Ptr("My external endpoint"), | ||
| Type: to.Ptr("Microsoft.network/TrafficManagerProfiles/ExternalEndpoints"), |
There was a problem hiding this comment.
The resource type string casing/format here is inconsistent with the rest of the examples in this package (e.g., Microsoft.Network/trafficManagerProfiles/externalEndpoints). These type strings are typically expected to match ARM resource type conventions, so this value is likely incorrect and can confuse users copying the snippet. Update it to the same canonical form used elsewhere in the examples.
Suggested change
| Type: to.Ptr("Microsoft.network/TrafficManagerProfiles/ExternalEndpoints"), | |
| Type: to.Ptr("Microsoft.Network/trafficManagerProfiles/externalEndpoints"), |
| TrafficRoutingMethod *TrafficRoutingMethod | ||
|
|
||
| // Indicates whether Traffic View is 'Enabled' or 'Disabled' for the Traffic Manager profile. Null, indicates 'Disabled'. | ||
| // Enabling this feature will increase the cost of the Traffic Manage profile. |
There was a problem hiding this comment.
Correct typo: “Traffic Manage profile” -> “Traffic Manager profile”.
Suggested change
| // Enabling this feature will increase the cost of the Traffic Manage profile. | |
| // Enabling this feature will increase the cost of the Traffic Manager profile. |
Comment on lines
+6
to
+7
| - Function `*EndpointsClient.Update` has been removed | ||
| - Function `*ProfilesClient.Update` has been removed |
There was a problem hiding this comment.
The changelog documents removal of the Update methods, but it doesn’t mention the related public type renames/removals that are part of the same breaking change (e.g., EndpointsClientUpdateOptions/EndpointsClientUpdateResponse and ProfilesClientUpdateOptions/ProfilesClientUpdateResponse being replaced by *UpdateV2* variants). Please add bullets under “Breaking Changes” covering those renamed/removed public types so consumers understand all compile-time breaks.
Suggested change
| - Function `*EndpointsClient.Update` has been removed | |
| - Function `*ProfilesClient.Update` has been removed | |
| - Function `*EndpointsClient.Update` has been removed | |
| - Type `EndpointsClientUpdateOptions` has been removed; use `EndpointsClientUpdateV2Options` instead | |
| - Type `EndpointsClientUpdateResponse` has been removed; use `EndpointsClientUpdateV2Response` instead | |
| - Function `*ProfilesClient.Update` has been removed | |
| - Type `ProfilesClientUpdateOptions` has been removed; use `ProfilesClientUpdateV2Options` instead | |
| - Type `ProfilesClientUpdateResponse` has been removed; use `ProfilesClientUpdateV2Response` instead |
| # Release History | ||
|
|
||
| ## 2.0.0-beta.1 (2026-03-16) | ||
| ## 2.0.0-beta.1 (2026-04-14) |
Member
There was a problem hiding this comment.
The 2022-04-01 package from the previous release request [AutoPR sdk-resourcemanager/trafficmanager/armtrafficmanager]-generated-from-SDK Generation - Go-60… hasn't been released yet, I've contacted with the service team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/trafficmanager/resource-manager/Microsoft.Network/TrafficManager/tspconfig.yaml', API Version: 2024-04-01-preview, SDK Release Type: beta, and CommitSHA: 'edf549eca6a93cb812a4a799f133ebb6726c76c8' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6155072 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=90f12233-d82d-f111-88b4-000d3a597030 Submitted by: ranjanasinha@microsoft.com
Release Plan Details
Spec pull request: Typespec changes for 2024-04-01-preview SDK release azure-rest-api-specs#41971
Spec API version: 2024-04-01-preview