Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug when PK is inhertied from a parent entity. #43801

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trande4884
Copy link
Member

@trande4884 trande4884 commented Jan 15, 2025

Description

When the bulk implementation was put in place it was accounted for pulling the PK from a parent entity, which caused problems with saveAll() and deleteAll(). This fixes those issues by finding the PK whether it is on the entity or a parent entity, tests were added also.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Jan 15, 2025
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@trande4884
Copy link
Member Author

/azp run java - spring - cosmos - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Can't save to CosmosDB if partition key fields are inherited from parent class
2 participants