New Data loader #43802
Open
New Data loader #43802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrm9084
requested review from
rujche,
Netyyyy,
saragluna and
moarychan
as code owners
samsadsam
reviewed
Jan 17, 2025
| @@ -44,8 +44,8 @@ final class AppConfigurationSnapshotPropertySource extends AppConfigurationAppli | |||
| * @param trim prefix to trim | |||
| * @throws InvalidConfigurationPropertyValueException thrown if fails to parse Json content type | |||
There was a problem hiding this comment.
should we add a description of isRefresh?
| public ConfigData load(ConfigDataLoaderContext context, AzureAppConfigDataResource resource) | ||
| throws IOException, ConfigDataResourceNotFoundException { | ||
| this.resource = resource; | ||
| storeState.setNextForcedRefresh(refreshInterval); |
There was a problem hiding this comment.
refreshInterval seems to be null here. Is that expected?
| throw new RuntimeException("Failed to generate property sources for " + resource.getEndpoint(), e); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
nit: params in the java docs do not align with the method signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix of this, updated to main, #41539 (Had trouble merging it.)