[OpenRewrite] Migrating azsdk-java-rewrite-recipes development to azure-sdk-for-java/core/openrewrite #43805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and branch protections during further development
jairmyree
requested review from
alzimmermsft,
srnagar,
anuchandy,
lmolkova,
vcolin7,
mssfang,
JonathanGiles and
billwert
as code owners
jairmyree
requested review from
g2vinay,
conniey,
rujche,
Netyyyy,
saragluna and
moarychan
as code owners
srnagar
reviewed
Jan 17, 2025
| @@ -0,0 +1,13 @@ | |||
| # Release History | |||
There was a problem hiding this comment.
I don't think we should bring in these azure-ai-translation-text-v1/2 samples into this repo. We should just ensure we have full tests to fully cover all the scenarios in the open rewrite packages.
| @@ -0,0 +1,102 @@ | |||
| # Azure Code Migration with OpenRewrite | |||
There was a problem hiding this comment.
We should not have openrewrite package in sdk/core directory. It should be in sdk/tools directory.
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import org.jetbrains.annotations.NotNull; | ||
| import org.openrewrite.*; |
There was a problem hiding this comment.
Wildcards in imports should not be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing over the code from
azure/azsdk-java-rewrite-recipesfor visibility and branch protections during further development