Fix test proxy network calls #45130
Draft
Fix test proxy network calls #45130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billwert
requested review from
alzimmermsft,
samvaity,
srnagar,
anuchandy,
lmolkova,
vcolin7,
mssfang and
JonathanGiles
as code owners
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
alzimmermsft
approved these changes
Apr 25, 2025
billwert
requested review from
hallipr,
weshaggard,
benbp and
JimSuplizio
as code owners
billwert
requested review from
christothes,
pvaneck,
KarishmaGhiya and
mpodwysocki
billwert
force-pushed
the
fix-test-proxy-network-calls
branch
from
8f52e72 to
f353fb3
Compare
… bodiless matchers.
joshfree
approved these changes
May 7, 2025
| @@ -331,7 +332,10 @@ public HttpClient getPlaybackClient() { | |||
| throw new IllegalStateException("A playback client can only be requested in PLAYBACK mode."); | |||
| } | |||
| if (testProxyPlaybackClient == null) { | |||
| testProxyPlaybackClient = new TestProxyPlaybackClient(httpClient, skipRecordingRequestBody); | |||
| // reactor.netty.http.client.HttpClient client = reactor.netty.http.client.HttpClient.create().wiretap("reactor.netty.http.client.HttpClient", LogLevel.TRACE, AdvancedByteBufFormat.TEXTUAL); | |||
There was a problem hiding this comment.
Did you want to remove this commented out code or if not add another comment above explaining when someone would want to make a swap here
There was a problem hiding this comment.
Definitely. This is really a draft PR at this point as we continue to chase down the problems. I'll clean a lot of things up when I'm done.
| while (true) { | ||
| try { | ||
| HttpResponse response = client.sendSync(request, Context.NONE); | ||
| if (response.getStatusCode() / 100 != 2) { |
There was a problem hiding this comment.
Should this be a helper since it's used multiple times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bunch of places where we were not properly closing a HttpResponse.