-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: Changed the visibility of the interface EmbeddingsOptions.setEncodingFormat
#46532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…els.EmbeddingsOptions.setEncodingFormat`、`com.azure.ai.openai.models.EmbeddingsOptions.getEncodingFormat` and the class `com.azure.ai.openai.models.EmbeddingEncodingFormat` to public Signed-off-by: Sun Yuhan <[email protected]>
Thank you for your contribution @sunyuhan1998! We will review the pull request and get back to you soon. |
@microsoft-github-policy-service agree |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
It seems my fix approach has some issues—this code appears to be generated rather than directly modifying the source files. To be honest, I'm not very familiar with this project. It would be great if someone could help fix this problem. |
@jpalvarezl could you verify this is fine to be made public? @sunyuhan1998 code generation has what we call a code customization (programmatic post generation code modification) here that is making the two types package-private: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/openai/azure-ai-openai/customization/src/main/java/OpenAICustomizations.java#L18-L19 Removing those lines should pass CI (pending the removal of trailing whitespace on that one line change). |
…penAICustomizations` Signed-off-by: Sun Yuhan <[email protected]>
Signed-off-by: Sun Yuhan <[email protected]>
Thank you very much for your help! I've tried making some adjustments according to your suggestions, and the situation seems to have improved a bit, but the CI is still failing. Could you please take another look and help me figure out the reason? Thank you! |
As stated in the issue, the visibility of
com.azure.ai.openai.models.EmbeddingsOptions.setEncodingFormat
,com.azure.ai.openai.models.EmbeddingsOptions.getEncodingFormat
, andcom.azure.ai.openai.models.EmbeddingEncodingFormat
should be public.Description
Changed the visibility of the interface
com.azure.ai.openai.models.EmbeddingsOptions.setEncodingFormat
、com.azure.ai.openai.models.EmbeddingsOptions.getEncodingFormat
and the classcom.azure.ai.openai.models.EmbeddingEncodingFormat
to publicFixes #46531
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines