Skip to content

Conversation

sunyuhan1998
Copy link

As stated in the issue, the visibility of com.azure.ai.openai.models.EmbeddingsOptions.setEncodingFormat, com.azure.ai.openai.models.EmbeddingsOptions.getEncodingFormat, and com.azure.ai.openai.models.EmbeddingEncodingFormat should be public.

Description

Changed the visibility of the interface com.azure.ai.openai.models.EmbeddingsOptions.setEncodingFormatcom.azure.ai.openai.models.EmbeddingsOptions.getEncodingFormat and the class com.azure.ai.openai.models.EmbeddingEncodingFormat to public

Fixes #46531

All SDK Contribution checklist:

  • [ ✅ ] The pull request does not introduce [breaking changes]
  • [ ✅ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [ ✅ ] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [ ✅ ] Title of the pull request is clear and informative.
  • [ ✅ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ ✅ ] Pull request includes test coverage for the included changes.

…els.EmbeddingsOptions.setEncodingFormat`、`com.azure.ai.openai.models.EmbeddingsOptions.getEncodingFormat` and the class `com.azure.ai.openai.models.EmbeddingEncodingFormat` to public

Signed-off-by: Sun Yuhan <[email protected]>
@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. OpenAI labels Aug 28, 2025
Copy link
Contributor

Thank you for your contribution @sunyuhan1998! We will review the pull request and get back to you soon.

@sunyuhan1998
Copy link
Author

@microsoft-github-policy-service agree

Copy link
Contributor

github-actions bot commented Aug 28, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure:azure-ai-openai

@sunyuhan1998
Copy link
Author

It seems my fix approach has some issues—this code appears to be generated rather than directly modifying the source files. To be honest, I'm not very familiar with this project. It would be great if someone could help fix this problem.

@alzimmermsft
Copy link
Member

@jpalvarezl could you verify this is fine to be made public?

@sunyuhan1998 code generation has what we call a code customization (programmatic post generation code modification) here that is making the two types package-private: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/openai/azure-ai-openai/customization/src/main/java/OpenAICustomizations.java#L18-L19

Removing those lines should pass CI (pending the removal of trailing whitespace on that one line change).

@sunyuhan1998
Copy link
Author

@jpalvarezl could you verify this is fine to be made public?

@sunyuhan1998 code generation has what we call a code customization (programmatic post generation code modification) here that is making the two types package-private: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/openai/azure-ai-openai/customization/src/main/java/OpenAICustomizations.java#L18-L19

Removing those lines should pass CI (pending the removal of trailing whitespace on that one line change).

Thank you very much for your help! I've tried making some adjustments according to your suggestions, and the situation seems to have improved a bit, but the CI is still failing. Could you please take another look and help me figure out the reason? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. OpenAI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The visibility of com.azure.ai.openai.models.EmbeddingsOptions#setEncodingFormat should be public
2 participants